From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias-Christian Ott Subject: Re: [PATCH 2/2] e1000e / PCI / PM: Add basic runtime PM support (rev. 4) Date: Mon, 15 Mar 2010 12:41:18 +0100 Message-ID: <20100315114117.GA1764@qp> References: <201003150131.59619.rjw@sisk.pl> <201003150135.17564.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <201003150135.17564.rjw@sisk.pl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: linux-pm@lists.linux-foundation.org List-Id: linux-pm@vger.kernel.org On Mon, Mar 15, 2010 at 01:35:17AM +0100, Rafael J. Wysocki wrote: > +static bool e1000e_pm_ready(struct e1000_adapter *adapter) > +{ > + return !!adapter->tx_ring->buffer_info; > +} Are your sure the double negation is right? Regards, Matthias-Christian