From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH 2/2] e1000e / PCI / PM: Add basic runtime PM support (rev. 4)
Date: Mon, 15 Mar 2010 20:28:41 +0100 [thread overview]
Message-ID: <201003152028.41953.rjw@sisk.pl> (raw)
In-Reply-To: <20100315114117.GA1764@qp>
On Monday 15 March 2010, Matthias-Christian Ott wrote:
> On Mon, Mar 15, 2010 at 01:35:17AM +0100, Rafael J. Wysocki wrote:
> > +static bool e1000e_pm_ready(struct e1000_adapter *adapter)
> > +{
> > + return !!adapter->tx_ring->buffer_info;
> > +}
>
> Are your sure the double negation is right?
Yes, the function should return true if the pointer is not NULL. It would work
without the !!, but I used it because of the types mismatch.
Rafael
next prev parent reply other threads:[~2010-03-15 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201003150131.59619.rjw@sisk.pl>
2010-03-15 0:33 ` [PATCH 1/2] r8169 / PCI / PM: Add simplified runtime PM support (rev. 3) Rafael J. Wysocki
2010-03-15 0:35 ` [PATCH 2/2] e1000e / PCI / PM: Add basic runtime PM support (rev. 4) Rafael J. Wysocki
[not found] ` <201003150135.17564.rjw@sisk.pl>
2010-03-15 11:41 ` Matthias-Christian Ott
2010-03-15 19:28 ` Rafael J. Wysocki [this message]
2010-03-17 4:29 ` David Miller
[not found] ` <201003150133.51239.rjw@sisk.pl>
2010-03-17 4:29 ` [PATCH 1/2] r8169 / PCI / PM: Add simplified runtime PM support (rev. 3) David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003152028.41953.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox