Re: [PATCH 0/8] Suspend block api (version 8)

mark gross
2010-06-03T05:40:18Z

On Wed, Jun 02, 2010 at 09:54:15PM -0700, Brian Swetland wrote:
> On Wed, Jun 2, 2010 at 8:18 PM, mark gross <640e9920@gmail.com> wrote:
> > On Wed, Jun 02, 2010 at 02:58:30PM -0700, Arve Hjønnevåg wrote:
> >>
> >> The list is not short. You have all the inactive and active
> >> constraints on the same list. If you change it to a two level list
> >> though, the list of unique values (which is the list you have to walk)
> >> may be short enough for a tree to be overkill.
> >
> > what have you seen in practice from the wake-lock stats?
> >
> > I'm having a hard time seeing where you could get more than just a
> > handfull.  However; one could go to a dual list (like the scheduler) and
> > move inactive nodes from an active to inactive list, or we could simply
> > remove them from the list uppon inactivity.  which would would well
> > after I change the api to have the client allocate the memory for the
> > nodes...  BUT, if your moving things in and out of a list a lot, I'm not
> > sure the break even point where changing the structure helps.
> >
> > We'll need to try it.
> >
> > I think we will almost never see more than 10 list elements.
> >
> > --mgross
> >
> >
>
> I see about 80 (based on the batteryinfo dump) on my Nexus One
> (QSD8250, Android Froyo):

shucks.

well I think for a pm_qos class that has boolean dynamic range we can
get away with not walking the list on every request update. we can use
a counter, and the list will be for mostly for stats.

> Kernel Wake lock "event5-86": (nothing executed)
> Kernel Wake lock "PowerManagerService": 4m 27s 994ms (453 times) realtime
> Kernel Wake lock "event4-92": 72ms (10 times) realtime
> Kernel Wake lock "AudioHardwareQSDIn": (nothing executed)
> Kernel Wake lock "event4-87": (nothing executed)
> Kernel Wake lock "event5-82": (nothing executed)
> Kernel Wake lock "event2-87": (nothing executed)
> Kernel Wake lock "alarm_rtc": 21s 882ms (186 times) realtime
> Kernel Wake lock "vdec_suspend": (nothing executed)
> Kernel Wake lock "event6-87": (nothing executed)
> Kernel Wake lock "event0-91": (nothing executed)
> Kernel Wake lock "SMD_DS": 30s 938ms (53 times) realtime
> Kernel Wake lock "event6-91": (nothing executed)
> Kernel Wake lock "KeyEvents": 398ms (3226 times) realtime
> Kernel Wake lock "qmi1": (nothing executed)
> Kernel Wake lock "mmc_delayed_work": (nothing executed)
> Kernel Wake lock "event3-82": (nothing executed)
> Kernel Wake lock "event3-92": 58ms (6 times) realtime
> Kernel Wake lock "SMD_RPCCALL": 295ms (1756 times) realtime
> Kernel Wake lock "SMD_DATA6": (nothing executed)
> Kernel Wake lock "audio_pcm_idle": 3s 99ms (1 times) realtime
> Kernel Wake lock "serial-debug": (nothing executed)
> Kernel Wake lock "event6-82": (nothing executed)
> Kernel Wake lock "event3-86": (nothing executed)
> Kernel Wake lock "event2-82": (nothing executed)
> Kernel Wake lock "i2c": (nothing executed)
> Kernel Wake lock "event2-86": (nothing executed)
> Kernel Wake lock "event5-87": (nothing executed)
> Kernel Wake lock "event4-86": (nothing executed)
> Kernel Wake lock "event5-92": 4ms (21 times) realtime
> Kernel Wake lock "rpc_server": (nothing executed)
> Kernel Wake lock "power-supply": 527ms (8 times) realtime
> Kernel Wake lock "radio-interface": 10s 11ms (10 times) realtime
> Kernel Wake lock "event6-86": (nothing executed)
> Kernel Wake lock "deleted_wake_locks": 203ms (214 times) realtime
> Kernel Wake lock "qmi0": (nothing executed)
> Kernel Wake lock "event2-91": (nothing executed)
> Kernel Wake lock "event4-82": (nothing executed)
> Kernel Wake lock "event7-82": (nothing executed)
> Kernel Wake lock "dock": 27ms (1 times) realtime
> Kernel Wake lock "SMD_DATA5": 1m 45s 121ms (158 times) realtime
> Kernel Wake lock "event1-92": (nothing executed)
> Kernel Wake lock "gpio_kp": (nothing executed)
> Kernel Wake lock "event3-87": (nothing executed)
> Kernel Wake lock "event7-92": (nothing executed)
> Kernel Wake lock "msm_serial_hs_dma": (nothing executed)
> Kernel Wake lock "event5-91": (nothing executed)
> Kernel Wake lock "vbus_present": 517ms (1 times) realtime
> Kernel Wake lock "alarm": 3s 229ms (249 times) realtime
> Kernel Wake lock "event1-82": (nothing executed)
> Kernel Wake lock "venc_suspend": (nothing executed)
> Kernel Wake lock "event1-86": (nothing executed)
> Kernel Wake lock "AudioHardwareQSDOut": 3s 98ms (1 times) realtime
> Kernel Wake lock "event0-87": (nothing executed)
> Kernel Wake lock "event2-92": 169ms (687 times) realtime
> Kernel Wake lock "ds2784-battery": 12s 846ms (158 times) realtime
> Kernel Wake lock "ApmCommandThread": 564ms (2 times) realtime
> Kernel Wake lock "msmfb_idle_lock": 1s 495ms (715 times) realtime
> Kernel Wake lock "headset": (nothing executed)
> Kernel Wake lock "kgsl": 26s 473ms (123 times) realtime
> Kernel Wake lock "venc_idle": (nothing executed)
> Kernel Wake lock "event1-91": (nothing executed)
> Kernel Wake lock "s5k3e2fx": (nothing executed)
> Kernel Wake lock "usb_mass_storage": (nothing executed)
> Kernel Wake lock "unknown_wakeups": (nothing executed)
> Kernel Wake lock "vdec_idle": (nothing executed)
> Kernel Wake lock "audio_pcm_suspend": 3s 99ms (1 times) realtime
> Kernel Wake lock "microp_i2c_present": (nothing executed)
> Kernel Wake lock "event4-91": (nothing executed)
> Kernel Wake lock "event6-92": 182ms (86 times) realtime
> Kernel Wake lock "event0-82": (nothing executed)
> Kernel Wake lock "event0-92": 8ms (37 times) realtime
> Kernel Wake lock "rpc_read": 112ms (1540 times) realtime
> Kernel Wake lock "event0-86": (nothing executed)
> Kernel Wake lock "msm_serial_hs_rx": (nothing executed)
> Kernel Wake lock "qmi2": (nothing executed)
> Kernel Wake lock "event1-87": (nothing executed)
> Kernel Wake lock "msm_camera": (nothing executed)
> Kernel Wake lock "rpc-interface": 2ms (1 times) realtime
> Kernel Wake lock "main": 1m 38s 314ms (5 times) realtime
> Kernel Wake lock "gpio_input": (nothing executed)
> Kernel Wake lock "event3-91": (nothing executed)
> Kernel Wake lock "SMD_DATA7": (nothing executed)

How much of this is portable to your next phone? I bet it was a big
effort to get these right too. FWIW I don't think most of these will
map into the moorestown port of android I'm working on.

This is why I really think a low power event framework would be cleaner
but, lets make everyone happy and expand pm_qos into a wake lock
re-implementation first.

--mgross