Re: [PATCH] opp: introduce library for device-specific OPPs

Phil Carmody
2010-09-17T16:45:43Z

On 17/09/10 17:36 +0200, ext Mark Brown wrote:
> On Thu, Sep 16, 2010 at 08:29:33PM -0500, Nishanth Menon wrote:
>
> > +struct opp_def {
> > + unsigned long freq;
> > + unsigned long u_volt;
> > +
> > + bool enabled;
> > +};
>
> It might be clearer to use some term other than enabled in the code -
> when reading I wasn't immediately sure if enabled meant that it was
> available to be selected or if it was the active operating point. How
^^^^^^^^^
> about 'allowed' (though I'm not 100% happy with that)?

I think your query contains its own answer.

Phil