From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-pci@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux-pm mailing list <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH] PCI / PCIe: Clear Root PME Status bits during early resume
Date: Sun, 19 Dec 2010 13:54:47 +0100 [thread overview]
Message-ID: <201012191354.47960.rjw@sisk.pl> (raw)
In-Reply-To: <201012191341.23601.rjw@sisk.pl>
On Sunday, December 19, 2010, Rafael J. Wysocki wrote:
> On Sunday, December 19, 2010, Rafael J. Wysocki wrote:
> > On Sunday, December 19, 2010, Matthew Wilcox wrote:
> > > On Sun, Dec 19, 2010 at 11:49:40AM +0100, Rafael J. Wysocki wrote:
> > > > in pci_pm_default_resume_early() and not in the port's resume
> > > > routine, because it's generally necessary even if the PCI Express
> > > > port driver is not used).
> > >
> > > We should make it impossible to not use the PCIe port driver.
> >
> > Actually, that's not correct. In some cases (e.g. _OSI doesn't allow us
>
> That should have been _OSC(), sorry.
>
> > to use PCIe native services), we simply can't use it (because it is unsafe
> > and leads to serious problems).
Well, in fact, scratch that. We can make it do nothing except for an early
resume routine doing the clearing of the Root PME Status bit in that cases.
I'll rework the patch in that direction.
Thanks,
Rafael
next prev parent reply other threads:[~2010-12-19 12:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201012191149.40547.rjw@sisk.pl>
2010-12-19 11:36 ` [PATCH] PCI / PCIe: Clear Root PME Status bits during early resume Matthew Wilcox
[not found] ` <20101219113658.GH1263@parisc-linux.org>
2010-12-19 12:38 ` Rafael J. Wysocki
[not found] ` <201012191338.24070.rjw@sisk.pl>
2010-12-19 12:41 ` Rafael J. Wysocki
[not found] ` <201012191341.23601.rjw@sisk.pl>
2010-12-19 12:54 ` Rafael J. Wysocki [this message]
2010-12-19 14:57 ` [PATCH] PCI / PCIe: Clear Root PME Status bits early during system resume Rafael J. Wysocki
[not found] ` <201012191557.16403.rjw@sisk.pl>
2010-12-23 20:54 ` Jesse Barnes
2010-12-19 10:49 [PATCH] PCI / PCIe: Clear Root PME Status bits during early resume Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012191354.47960.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox