From: Pavel Machek <pavel@ucw.cz>
To: Len Brown <lenb@kernel.org>
Cc: linux-pm@lists.linux-foundation.org, stable@kernel.org
Subject: Re: [PATCH 1/2 2.6.37.stable] intel_idle: disable NHM/WSM HW C-state auto-demotion
Date: Fri, 15 Apr 2011 18:25:42 +0200 [thread overview]
Message-ID: <20110415162542.GB22806@elf.ucw.cz> (raw)
In-Reply-To: <alpine.LFD.2.02.1104081215120.27120@x980>
Hi!
> > > @@ -85,6 +86,12 @@ static int intel_idle(struct cpuidle_dev
> > > static struct cpuidle_state *cpuidle_state_table;
> > >
> > > /*
> > > + * Hardware C-state auto-demotion may not always be optimal.
> > > + * Indicate which enable bits to clear here.
> > > + */
> > > +static unsigned long long auto_demotion_disable_flags;
> >
> > Why long long here, but long above?
>
> long long here because MSR accesses are 64-bits, even on
> 32-bit builds.
>
> UL above because it matches the style of the neighboring code.
> The "UL" is purely cosmetic, of course. Same code is generated
> if it were "ULL" or left off entirely; as the LHS is 64-bit.
Normally, if register is always 64bit, it should be u64.
And consistency should not be a reason to add misleading postfixes...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2011-04-15 16:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 2:24 [PATCH 1/2 2.6.37.stable] intel_idle: disable NHM/WSM HW C-state auto-demotion Len Brown
2011-03-23 2:26 ` [PATCH 2/2 2.6.37.stable] intel_idle: disable Atom/Lincroft " Len Brown
2011-03-23 22:55 ` [stable] " Greg KH
2011-03-23 22:54 ` [stable] [PATCH 1/2 2.6.37.stable] intel_idle: disable NHM/WSM " Greg KH
[not found] ` <20110323225420.GE27334@kroah.com>
2011-03-24 2:53 ` Len Brown
2011-03-24 3:39 ` Greg KH
2011-04-08 13:16 ` Pavel Machek
2011-04-08 16:14 ` Len Brown
2011-04-08 13:16 ` Pavel Machek
2011-04-08 22:31 ` Len Brown
2011-04-15 16:25 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110415162542.GB22806@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=lenb@kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox