public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Linux PM mailing list <linux-pm@lists.linux-foundation.org>
Cc: linux-sh@vger.kernel.org, Greg KH <gregkh@suse.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Grant Likely <grant.likely@secretlab.ca>
Subject: [PATCH 6/9] PM / Runtime: Add subsystem data field to struct dev_pm_info
Date: Sun, 17 Apr 2011 01:40:40 +0200	[thread overview]
Message-ID: <201104170140.40557.rjw@sisk.pl> (raw)
In-Reply-To: <201104170135.19388.rjw@sisk.pl>

From: Rafael J. Wysocki <rjw@sisk.pl>

Some subsystems need to attach PM-related data to struct device and
they need to use devres for this purpose.  For their convenience
and to make code more straightforward, add a new field called
subsys_data to struct dev_pm_info and let subsystems use it for
attaching PM-related information to devices.

Convert the ARM shmobile platform to using the new field.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 arch/arm/mach-shmobile/pm_runtime.c |   34 +++++++++++++++++-----------------
 include/linux/pm.h                  |    1 +
 2 files changed, 18 insertions(+), 17 deletions(-)

Index: linux-2.6/include/linux/pm.h
===================================================================
--- linux-2.6.orig/include/linux/pm.h
+++ linux-2.6/include/linux/pm.h
@@ -460,6 +460,7 @@ struct dev_pm_info {
 	unsigned long		active_jiffies;
 	unsigned long		suspended_jiffies;
 	unsigned long		accounting_timestamp;
+	void			*subsys_data;  /* Owned by the subsystem. */
 #endif
 };
 
Index: linux-2.6/arch/arm/mach-shmobile/pm_runtime.c
===================================================================
--- linux-2.6.orig/arch/arm/mach-shmobile/pm_runtime.c
+++ linux-2.6/arch/arm/mach-shmobile/pm_runtime.c
@@ -18,6 +18,7 @@
 #include <linux/clk.h>
 #include <linux/sh_clk.h>
 #include <linux/bitmap.h>
+#include <linux/slab.h>
 
 #ifdef CONFIG_PM_RUNTIME
 #define BIT_ONCE 0
@@ -29,22 +30,9 @@ struct pm_runtime_data {
 	struct clk *clk;
 };
 
-static void __devres_release(struct device *dev, void *res)
-{
-	struct pm_runtime_data *prd = res;
-
-	dev_dbg(dev, "__devres_release()\n");
-
-	if (test_bit(BIT_CLK_ENABLED, &prd->flags))
-		clk_disable(prd->clk);
-
-	if (test_bit(BIT_ACTIVE, &prd->flags))
-		clk_put(prd->clk);
-}
-
 static struct pm_runtime_data *__to_prd(struct device *dev)
 {
-	return devres_find(dev, __devres_release, NULL, NULL);
+	return dev ? dev->power.subsys_data : NULL;
 }
 
 static void platform_pm_runtime_init(struct device *dev,
@@ -121,14 +109,26 @@ static int platform_bus_notify(struct no
 
 	dev_dbg(dev, "platform_bus_notify() %ld !\n", action);
 
-	if (action == BUS_NOTIFY_BIND_DRIVER) {
-		prd = devres_alloc(__devres_release, sizeof(*prd), GFP_KERNEL);
+	switch (action) {
+	case BUS_NOTIFY_BIND_DRIVER:
+		prd = kzalloc(sizeof(*prd), GFP_KERNEL);
 		if (prd) {
-			devres_add(dev, prd);
+			dev->power.subsys_data = prd;
 			dev->pwr_domain = &default_power_domain;
 		} else {
 			dev_err(dev, "unable to alloc memory for runtime pm\n");
 		}
+		break;
+	case BUS_NOTIFY_UNBOUND_DRIVER:
+		prd = __to_prd(dev);
+		if (prd) {
+			if (test_bit(BIT_CLK_ENABLED, &prd->flags))
+				clk_disable(prd->clk);
+
+			if (test_bit(BIT_ACTIVE, &prd->flags))
+				clk_put(prd->clk);
+		}
+		break;
 	}
 
 	return 0;

  parent reply	other threads:[~2011-04-16 23:40 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201104130205.26988.rjw@sisk.pl>
2011-04-13 14:17 ` [RFC][PATCH] PM: Make power domain callbacks take precedence over subsystem ones Alan Stern
     [not found] ` <Pine.LNX.4.44L0.1104130954270.2005-100000@iolanthe.rowland.org>
2011-04-13 16:15   ` Grant Likely
     [not found]   ` <BANLkTiknpAkUQMaq3WZSTHy2cs-vXkv08Q@mail.gmail.com>
2011-04-14 23:12     ` Rafael J. Wysocki
     [not found]     ` <201104150112.24722.rjw@sisk.pl>
2011-04-15 14:38       ` Grant Likely
2011-04-15 14:39       ` Alan Stern
2011-04-14 18:20 ` Magnus Damm
     [not found] ` <BANLkTimQ6kX41-53Dw2RqEVyYzbT2qbz9Q@mail.gmail.com>
2011-04-14 22:45   ` Rafael J. Wysocki
2011-04-14 23:16 ` [RFC][PATCH 0/2] Remove __weak definitions of platform PM callbacks Rafael J. Wysocki
     [not found] ` <201104150116.01634.rjw@sisk.pl>
2011-04-14 23:18   ` [RFC][PATCH 1/2] shmobile: Use power domains for platform runtime PM Rafael J. Wysocki
2011-04-14 23:19   ` [RFC][PATCH 2/2] PM / Platform: Use generic runtime PM callbacks directly Rafael J. Wysocki
2011-04-16 17:17 ` [RFC][PATCH] PM: Make power domain callbacks take precedence over subsystem ones Kevin Hilman
2011-04-16 23:35 ` [PATCH 0/9] PM: Rework shmobile and OMAP runtime PM using power domains Rafael J. Wysocki
     [not found] ` <201104170135.19388.rjw@sisk.pl>
2011-04-16 23:36   ` [PATCH 1/9] PM: Make power domain callbacks take precedence over subsystem ones Rafael J. Wysocki
2011-04-16 23:37   ` [PATCH 2/9] PM: Export platform bus type's default PM callbacks Rafael J. Wysocki
2011-04-16 23:38   ` [PATCH 3/9] shmobile: Use power domains for platform runtime PM Rafael J. Wysocki
2011-04-16 23:38   ` [PATCH 4/9] PM / Platform: Use generic runtime PM callbacks directly Rafael J. Wysocki
2011-04-16 23:39   ` [PATCH 5/9] OMAP2+ / PM: Move runtime PM implementation to use power domains Rafael J. Wysocki
2011-04-16 23:40   ` Rafael J. Wysocki [this message]
2011-04-16 23:42   ` [PATCH 7/9] PM / Runtime: Add generic clock manipulation rountines for runtime PM Rafael J. Wysocki
2011-04-18 19:59     ` [Update][PATCH " Rafael J. Wysocki
     [not found]     ` <201104182159.54316.rjw@sisk.pl>
2011-04-19 10:18       ` Magnus Damm
     [not found]       ` <BANLkTimZpXAH7uGTDmYJSJJWgX=H5md0JQ@mail.gmail.com>
2011-04-19 21:42         ` Rafael J. Wysocki
     [not found]         ` <201104182157.28373.rjw@sisk.pl>
     [not found]           ` <201104192342.26670.rjw@sisk.pl>
2011-04-19 21:59             ` Paul Mundt
     [not found]             ` <20110419215944.GA10031@linux-sh.org>
2011-04-19 22:10               ` Rafael J. Wysocki
     [not found]               ` <201104200010.50656.rjw@sisk.pl>
2011-04-19 22:20                 ` Paul Mundt
2011-04-19 22:50                   ` Rafael J. Wysocki
2011-04-19 10:58     ` [PATCH " Mark Brown
     [not found]     ` <20110419105836.GG9462@sirena.org.uk>
2011-04-19 21:35       ` Rafael J. Wysocki
     [not found]       ` <201104192335.34560.rjw@sisk.pl>
2011-04-20 11:57         ` Mark Brown
2011-04-16 23:43   ` [PATCH 8/9] OMAP1 / PM: Use generic clock manipulation routines " Rafael J. Wysocki
2011-04-16 23:44   ` [PATCH 9/9] PM: Revert "driver core: platform_bus: allow runtime override of dev_pm_ops" Rafael J. Wysocki
     [not found]   ` <201104170143.28980.rjw@sisk.pl>
2011-04-18  8:18     ` [PATCH 8/9] OMAP1 / PM: Use generic clock manipulation routines for runtime PM Paul Mundt
     [not found]     ` <20110418081809.GA32457@linux-sh.org>
2011-04-18 19:57       ` Rafael J. Wysocki
2011-04-24 21:30   ` [PATCH 0/9] PM: Rework shmobile and OMAP runtime PM using power domains (v2) Rafael J. Wysocki
     [not found]   ` <201104242330.13607.rjw@sisk.pl>
2011-04-24 21:36     ` [PATCH 1/9] PM: Make power domain callbacks take precedence over subsystem ones Rafael J. Wysocki
2011-04-24 21:37     ` [PATCH 2/9] PM: Export platform bus type's default PM callbacks Rafael J. Wysocki
2011-04-24 21:38     ` [PATCH 3/9] shmobile: Use power domains for platform runtime PM Rafael J. Wysocki
2011-04-24 21:39     ` [PATCH 4/9] PM / Platform: Use generic runtime PM callbacks directly Rafael J. Wysocki
2011-04-24 21:41     ` [PATCH 5/9] OMAP2+ / PM: move runtime PM implementation to use device power domains Rafael J. Wysocki
2011-04-24 21:42     ` [PATCH 6/9] PM / Runtime: Add subsystem data field to struct dev_pm_info Rafael J. Wysocki
2011-04-24 21:42     ` [PATCH 7/9] PM / Runtime: Generic clock manipulation rountines for runtime PM (v2) Rafael J. Wysocki
2011-04-24 21:43     ` [PATCH 8/9] OMAP1 / PM: Use generic clock manipulation routines for runtime PM Rafael J. Wysocki
2011-04-24 21:44     ` [PATCH 9/9] PM: Revert "driver core: platform_bus: allow runtime override of dev_pm_ops" Rafael J. Wysocki
2011-04-24 23:36     ` [PATCH 0/9] PM: Rework shmobile and OMAP runtime PM using power domains (v2) Greg KH
     [not found]     ` <201104242342.58326.rjw@sisk.pl>
2011-04-27 21:48       ` [Update][PATCH 7/9] PM / Runtime: Generic clock manipulation rountines for runtime PM (v3) Rafael J. Wysocki
     [not found]       ` <201104272348.24084.rjw@sisk.pl>
2011-04-27 23:04         ` Colin Cross
     [not found]         ` <BANLkTimHkKq9+0z-4CZs=34GNO6Ab0wZPQ@mail.gmail.com>
2011-04-28  0:58           ` Rafael J. Wysocki
     [not found]           ` <201104280258.34694.rjw@sisk.pl>
2011-04-28  1:06             ` Rafael J. Wysocki
     [not found]             ` <201104280306.13262.rjw@sisk.pl>
2011-04-28  1:33               ` Rafael J. Wysocki
     [not found]               ` <201104280333.13730.rjw@sisk.pl>
2011-04-28 19:36                 ` [Update x2][PATCH 7/9] PM / Runtime: Generic clock manipulation rountines for runtime PM (v5) Rafael J. Wysocki
     [not found]                 ` <201104282136.26163.rjw@sisk.pl>
2011-04-29 19:35                   ` Stephen Boyd
     [not found]                   ` <4DBB12EF.9030000@codeaurora.org>
2011-04-29 20:29                     ` Rafael J. Wysocki
     [not found]                     ` <201104292229.56518.rjw@sisk.pl>
2011-04-29 22:04                       ` [Update x3][PATCH 7/9] PM / Runtime: Generic clock manipulation rountines for runtime PM (v6) Rafael J. Wysocki
     [not found]                       ` <201104300004.02601.rjw@sisk.pl>
2011-05-03 17:00                         ` Stephen Boyd
     [not found]                         ` <4DC034CA.6000505@codeaurora.org>
2011-05-03 17:38                           ` Rafael J. Wysocki
2011-04-29 20:50             ` [Update][PATCH 7/9] PM / Runtime: Generic clock manipulation rountines for runtime PM (v3) Grant Likely
     [not found]             ` <20110429205039.GB7497@ponder.secretlab.ca>
2011-04-29 21:07               ` Rafael J. Wysocki
     [not found]     ` <201104242343.41456.rjw@sisk.pl>
2011-05-16 10:16       ` [PATCH 8/9] OMAP1 / PM: Use generic clock manipulation routines for runtime PM Kevin Hilman
     [not found]       ` <87mxindk7m.fsf@ti.com>
2011-05-16 18:26         ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201104170140.40557.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=grant.likely@secretlab.ca \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox