public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Nishanth Menon <nm@ti.com>, Len Brown <len.brown@intel.com>,
	Kevin Hilman <khilman@deeprootsystems.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	linux-pm@lists.linux-foundation.org
Subject: Re: [RFC PATCH] PM: Introduce generic DVFS framework with device-specific OPPs
Date: Wed, 27 Apr 2011 15:46:12 +0200	[thread overview]
Message-ID: <201104271546.12757.rjw@sisk.pl> (raw)
In-Reply-To: <BANLkTi=tBYT4NpayaoAA1+f1uaj9QyT+Yw@mail.gmail.com>

On Wednesday, April 27, 2011, MyungJoo Ham wrote:
> Hello,
> 
> 2011/4/26 Rafael J. Wysocki <rjw@sisk.pl>:
> > Hi,
> >
...
> >> +
> >> +/**
> >> + * dvfs_tickle_device() - Guarantee maximum operation speed for a while
> >> + *                   instaneously.
> >> + * @dev:     the device to be tickled.
> >> + * @duration_ms:     the duration of tickle effect.
> >> + *
> >> + * Tickle sets the device at the maximum frequency instaneously and
> >> + * the maximul frequency is guaranteed to be used for the given duration.
> >          ^^^^^^^
> > I guess that should be "maximum".
> 
> Yes. :)
> 
> >
> >> + * For faster user reponse time, an input event may tickle a related device
> >> + * so that the input event does not need to wait for the DVFS to react with
> >> + * normal interval.
> >> + */
> >
> > Can you explain how this function is supposed to be used, please?
> 
> Ok, I'll show you a usage example
> 
> The system: a touchscreen based computer with DVFS'able GPU.
> Use case: a user scrolls the screen with fingers suddenly. (think of
> an iPhone or Android device's home screen filled wit icons)
> While there is no touchscreen input (thus, the screen does not move
> fast), we do not use GPU too much; thus it is scaled to run at slower
> rate (let's say 100MHz).
> If a user suddenly touches screen and starts moving, the screen should
> follow it; thus, requires much output from GPU.
> With normal DVFS-GPU, it would take some time to speed it up because
> it should monitor the GPU usage and react afterwards.
> 
> With the API given, "tickle" may be included in the user input event.
> So that GPU can be scaled to maximum frequency immediately.

So in this case the input subsystem would be calling dvfs_tickle_device()
(or whatever it is finally called) for the GPU, right?

I'm afraid you'd need a user space interface for that and let the
application (or library) handling the touchpad input control the "tickle".
Otherwise it would be difficult to arrange things correctly (the association
between the input subsystem and the GPU is not obvious at the kernel level).

Ideally, though, the working OPP for the GPU should depend on the number of
processing requests per a unit of time, pretty much like for a CPU.

> If the monitoring frequency is 50ms, DVFS will likely to react with
> about 75ms of delay.
> For example, if the touch event has occurred at 25ms after the last
> DVFS monitoring event, at the next DVFS monitoring event, the measured
> load will be about 50%, which usually won't require DVFS to speed up.
> Then, DVFS will react at the next monitoring event; thus, it took 50ms
> + 25ms.
> 
> 75ms is enough to give some impression to users. These days, many
> mobile devices require 60Hz-based UI, which is about 16ms.
> 
> Anyway, this happens with drivers/cpufreq also. We have been testing
> "tickling" associated with drivers/cpufreq/cpufreq.c. This has been
> reduced user response time significantly removing the need for tuning
> the threshold values.

I think I understand the problem, but I'm not sure if there's a clean way
to trigger the "tickle" from the kernel level.

Thanks,
Rafael

  reply	other threads:[~2011-04-27 13:46 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-26  8:43 [RFC PATCH] PM: Introduce generic DVFS framework with device-specific OPPs MyungJoo Ham
2011-04-26 11:09 ` Rafael J. Wysocki
2011-04-27  5:22   ` MyungJoo Ham
2011-04-27 13:46     ` Rafael J. Wysocki [this message]
2011-04-28  6:54       ` MyungJoo Ham
2011-04-28 19:19         ` Rafael J. Wysocki
2011-04-27 17:49     ` Colin Cross
2011-04-27 18:07       ` Menon, Nishanth
     [not found]       ` <BANLkTin4rrniJpOheLH=JE0jq7vFpdDbrA@mail.gmail.com>
2011-04-27 18:29         ` Colin Cross
     [not found]         ` <BANLkTi=WWASxk3Fz83324k40Lbq+ccAPeA@mail.gmail.com>
2011-04-27 18:37           ` Colin Cross
2011-04-27 18:48           ` Menon, Nishanth
     [not found]           ` <BANLkTikEtTDp3Cpj0D5z34wA0_G_DWwKFg@mail.gmail.com>
2011-04-27 18:54             ` Colin Cross
2011-04-27 19:26             ` Thomas Gleixner
     [not found]             ` <alpine.LFD.2.02.1104272104390.3323@ionos>
2011-04-27 20:48               ` Colin Cross
     [not found]               ` <BANLkTinWD0ktYKzR_jnQSE76AuW+Z1PSLw@mail.gmail.com>
2011-04-28  6:12                 ` MyungJoo Ham
     [not found]                 ` <BANLkTi=Be3DrAUoPmgHpjhAVmN-Pi5Au7g@mail.gmail.com>
2011-04-28  6:44                   ` Colin Cross
     [not found]                   ` <BANLkTiniJUgTTDh7SF8yNMeSMa+JYM21wA@mail.gmail.com>
2011-04-28  6:50                     ` MyungJoo Ham
     [not found]                     ` <BANLkTimzWyvcBV2ymxaMf=HmRhGYBboB1w@mail.gmail.com>
2011-04-28  7:06                       ` Colin Cross
     [not found]                       ` <BANLkTik6L8HkJ0YjQYjh_3eEmbffyk1kRA@mail.gmail.com>
2011-04-28  7:34                         ` MyungJoo Ham
2011-04-28 12:19                 ` Mark Brown
     [not found]           ` <BANLkTinP0_qpF3sp8CzDy42i24wqqo7ohw@mail.gmail.com>
2011-04-28  5:59             ` MyungJoo Ham
     [not found]             ` <BANLkTin-OMyrz=McN6X4TAZrvv3ehVBGew@mail.gmail.com>
2011-04-28  6:43               ` Colin Cross
     [not found]               ` <BANLkTikVHs1n8fXEAZh6Q4io39eD9PG14w@mail.gmail.com>
2011-04-28  7:16                 ` MyungJoo Ham
2011-04-27 19:00         ` Thomas Gleixner
2011-04-27 18:34       ` Mark Brown
2011-04-27 18:45         ` Colin Cross
2011-04-27 18:58           ` Mark Brown
2011-04-26 13:22 ` Greg KH
2011-04-26 14:45   ` Jiejing.Zhang 
2011-04-26 20:54     ` Greg KH
2011-04-27  5:33       ` MyungJoo Ham
2011-04-27 13:49         ` Rafael J. Wysocki
2011-04-27 13:36       ` Mark Brown
2011-04-26 19:45   ` Pavel Machek
2011-04-26 15:07 ` Mark Brown
2011-04-27  5:24   ` MyungJoo Ham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201104271546.12757.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=gregkh@suse.de \
    --cc=khilman@deeprootsystems.com \
    --cc=kyungmin.park@samsung.com \
    --cc=len.brown@intel.com \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=nm@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox