From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH] apm-emulation: Fix mutex race condition
Date: Tue, 3 May 2011 22:33:51 +0200
Message-ID: <201105032233.51918.rjw@sisk.pl>
References: <729677.85794.qm@web29008.mail.ird.yahoo.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <linux-pm-bounces@lists.linux-foundation.org>
In-Reply-To: <729677.85794.qm@web29008.mail.ird.yahoo.com>
List-Unsubscribe: <https://lists.linux-foundation.org/mailman/listinfo/linux-pm>,
	<mailto:linux-pm-request@lists.linux-foundation.org?subject=unsubscribe>
List-Archive: <http://lists.linux-foundation.org/pipermail/linux-pm>
List-Post: <mailto:linux-pm@lists.linux-foundation.org>
List-Help: <mailto:linux-pm-request@lists.linux-foundation.org?subject=help>
List-Subscribe: <https://lists.linux-foundation.org/mailman/listinfo/linux-pm>,
	<mailto:linux-pm-request@lists.linux-foundation.org?subject=subscribe>
Sender: linux-pm-bounces@lists.linux-foundation.org
Errors-To: linux-pm-bounces@lists.linux-foundation.org
To: Paul Parsons <lost.distance@yahoo.com>
Cc: Jiri Kosina <jkosina@suse.cz>, linux-pm@lists.linux-foundation.org
List-Id: linux-pm@vger.kernel.org

On Tuesday, May 03, 2011, Paul Parsons wrote:
> Hi Rafael,
> 
> --- On Tue, 3/5/11, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > Hmm.  I'd rather use mutex_trylock() and call try_to_freeze() if
> > that fails.
> > 
> > Is there anything wrong with this approach?
> 
> Well, mutex_trylock() doesn't wait if it cannot acquire the mutex, so won't the calling process enter a busy loop if it fails?

Right.  So I don't see how we could do better that in your patch at the
moment.

I'm not sure if Jiri is going to take your patch.  I will if he doesn't.

Thanks,
Rafael