Re: [PATCH] apm-emulation: Fix mutex race condition

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Wednesday, May 04, 2011, Jiri Kosina wrote:
> On Tue, 3 May 2011, Rafael J. Wysocki wrote:
> 
> > > --- On Tue, 3/5/11, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > > > Hmm.  I'd rather use mutex_trylock() and call try_to_freeze() if
> > > > that fails.
> > > > 
> > > > Is there anything wrong with this approach?
> > > 
> > > Well, mutex_trylock() doesn't wait if it cannot acquire the mutex, so 
> > > won't the calling process enter a busy loop if it fails?
> > 
> > Right.  So I don't see how we could do better that in your patch at the
> > moment.
> 
> Right, neither do I.
> 
> > I'm not sure if Jiri is going to take your patch.  I will if he doesn't.
> 
> I can add drivers/char/apm-emulation.c as the one maintained under the 
> 'APM' roof, and take this, no problem.
> 
> Rafael, I take it that I can add your Ack to this patch, right?

That's correct.

Thanks,
Rafael