public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Linux PM mailing list <linux-pm@lists.linux-foundation.org>
Cc: linux-sh@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 5/10 v6] PM / Domains: Move code from under #ifdef CONFIG_PM_RUNTIME (v2)
Date: Sat, 25 Jun 2011 23:27:49 +0200	[thread overview]
Message-ID: <201106252327.49552.rjw@sisk.pl> (raw)
In-Reply-To: <201106252324.13454.rjw@sisk.pl>

From: Rafael J. Wysocki <rjw@sisk.pl>

There is some code in drivers/base/power/domain.c that will be useful
for both runtime PM and system-wide power transitions, so make it
depend on CONFIG_PM instead of CONFIG_PM_RUNTIME.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 drivers/base/power/domain.c |  120 +++++++++++++++++++++++---------------------
 1 file changed, 65 insertions(+), 55 deletions(-)

Index: linux-2.6/drivers/base/power/domain.c
===================================================================
--- linux-2.6.orig/drivers/base/power/domain.c
+++ linux-2.6/drivers/base/power/domain.c
@@ -14,7 +14,15 @@
 #include <linux/slab.h>
 #include <linux/err.h>
 
-#ifdef CONFIG_PM_RUNTIME
+#ifdef CONFIG_PM
+
+static struct generic_pm_domain *dev_to_genpd(struct device *dev)
+{
+	if (IS_ERR_OR_NULL(dev->pm_domain))
+		return ERR_PTR(-EINVAL);
+
+	return container_of(dev->pm_domain, struct generic_pm_domain, domain);
+}
 
 static void genpd_sd_counter_dec(struct generic_pm_domain *genpd)
 {
@@ -23,6 +31,58 @@ static void genpd_sd_counter_dec(struct
 }
 
 /**
+ * pm_genpd_poweron - Restore power to a given PM domain and its parents.
+ * @genpd: PM domain to power up.
+ *
+ * Restore power to @genpd and all of its parents so that it is possible to
+ * resume a device belonging to it.
+ */
+static int pm_genpd_poweron(struct generic_pm_domain *genpd)
+{
+	int ret = 0;
+
+ start:
+	if (genpd->parent)
+		mutex_lock(&genpd->parent->lock);
+	mutex_lock(&genpd->lock);
+
+	if (!genpd->power_is_off)
+		goto out;
+
+	if (genpd->parent && genpd->parent->power_is_off) {
+		mutex_unlock(&genpd->lock);
+		mutex_unlock(&genpd->parent->lock);
+
+		ret = pm_genpd_poweron(genpd->parent);
+		if (ret)
+			return ret;
+
+		goto start;
+	}
+
+	if (genpd->power_on) {
+		int ret = genpd->power_on(genpd);
+		if (ret)
+			goto out;
+	}
+
+	genpd->power_is_off = false;
+	if (genpd->parent)
+		genpd->parent->sd_count++;
+
+ out:
+	mutex_unlock(&genpd->lock);
+	if (genpd->parent)
+		mutex_unlock(&genpd->parent->lock);
+
+	return ret;
+}
+
+#endif /* CONFIG_PM */
+
+#ifdef CONFIG_PM_RUNTIME
+
+/**
  * __pm_genpd_save_device - Save the pre-suspend state of a device.
  * @dle: Device list entry of the device to save the state of.
  * @genpd: PM domain the device belongs to.
@@ -174,11 +234,10 @@ static int pm_genpd_runtime_suspend(stru
 
 	dev_dbg(dev, "%s()\n", __func__);
 
-	if (IS_ERR_OR_NULL(dev->pm_domain))
+	genpd = dev_to_genpd(dev);
+	if (IS_ERR(genpd))
 		return -EINVAL;
 
-	genpd = container_of(dev->pm_domain, struct generic_pm_domain, domain);
-
 	if (genpd->parent)
 		mutex_lock(&genpd->parent->lock);
 	mutex_lock(&genpd->lock);
@@ -201,54 +260,6 @@ static int pm_genpd_runtime_suspend(stru
 }
 
 /**
- * pm_genpd_poweron - Restore power to a given PM domain and its parents.
- * @genpd: PM domain to power up.
- *
- * Restore power to @genpd and all of its parents so that it is possible to
- * resume a device belonging to it.
- */
-static int pm_genpd_poweron(struct generic_pm_domain *genpd)
-{
-	int ret = 0;
-
- start:
-	if (genpd->parent)
-		mutex_lock(&genpd->parent->lock);
-	mutex_lock(&genpd->lock);
-
-	if (!genpd->power_is_off)
-		goto out;
-
-	if (genpd->parent && genpd->parent->power_is_off) {
-		mutex_unlock(&genpd->lock);
-		mutex_unlock(&genpd->parent->lock);
-
-		ret = pm_genpd_poweron(genpd->parent);
-		if (ret)
-			return ret;
-
-		goto start;
-	}
-
-	if (genpd->power_on) {
-		int ret = genpd->power_on(genpd);
-		if (ret)
-			goto out;
-	}
-
-	genpd->power_is_off = false;
-	if (genpd->parent)
-		genpd->parent->sd_count++;
-
- out:
-	mutex_unlock(&genpd->lock);
-	if (genpd->parent)
-		mutex_unlock(&genpd->parent->lock);
-
-	return ret;
-}
-
-/**
  * pm_genpd_runtime_resume - Resume a device belonging to I/O PM domain.
  * @dev: Device to resume.
  *
@@ -264,11 +275,10 @@ static int pm_genpd_runtime_resume(struc
 
 	dev_dbg(dev, "%s()\n", __func__);
 
-	if (IS_ERR_OR_NULL(dev->pm_domain))
+	genpd = dev_to_genpd(dev);
+	if (IS_ERR(genpd))
 		return -EINVAL;
 
-	genpd = container_of(dev->pm_domain, struct generic_pm_domain, domain);
-
 	ret = pm_genpd_poweron(genpd);
 	if (ret)
 		return ret;

  parent reply	other threads:[~2011-06-25 21:27 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-11 20:23 [PATCH 0/8] PM / Domains: Support for generic I/O PM domains (v5) Rafael J. Wysocki
2011-06-11 20:25 ` [PATCH 1/8] PM / Domains: Update documentation Rafael J. Wysocki
2011-06-11 20:26 ` [PATCH 2/8] PM / Domains: Rename struct dev_power_domain to struct dev_pm_domain Rafael J. Wysocki
2011-06-11 20:27 ` [PATCH 3/8] PM: subsys_data in struct dev_pm_info need not depend on RM_RUNTIME Rafael J. Wysocki
2011-06-11 20:31 ` [PATCH 4/8] PM / Domains: Support for generic I/O PM domains (v5) Rafael J. Wysocki
2011-06-11 20:36 ` [PATCH 5/8] PM: Introduce generic "noirq" callback routines for subsystems Rafael J. Wysocki
2011-06-11 20:37 ` [PATCH 6/8] PM / Domains: Move code from under #ifdef CONFIG_PM_RUNTIME Rafael J. Wysocki
2011-06-11 20:39 ` [PATCH 7/8] PM / Domains: System-wide transitions support for generic PM domains Rafael J. Wysocki
2011-06-11 20:40 ` [PATCH 8/8] ARM / shmobile: Support for I/O PM domains for SH7372 (v5) Rafael J. Wysocki
2011-06-11 20:57 ` [PATCH 0/8] PM / Domains: Support for generic I/O PM domains (v5) Greg KH
     [not found] ` <201106112240.11621.rjw@sisk.pl>
2011-06-14 13:12   ` [PATCH 8/8] ARM / shmobile: Support for I/O PM domains for SH7372 (v5) Magnus Damm
     [not found]   ` <BANLkTi=-1Fpp9L17T7CwxoO9JfSes4FeKg@mail.gmail.com>
2011-06-14 21:16     ` Rafael J. Wysocki
     [not found]     ` <201106142316.02812.rjw@sisk.pl>
2011-06-15 14:17       ` Magnus Damm
     [not found]       ` <BANLkTi=u_eyGZt9e0CuVpyz9B08HarEyVw@mail.gmail.com>
2011-06-15 23:06         ` Rafael J. Wysocki
     [not found]         ` <201106160106.40553.rjw@sisk.pl>
2011-06-19 22:07           ` [Update][PATCH 8/8] ARM / shmobile: Support for I/O power domains for SH7372 (v6) Rafael J. Wysocki
     [not found]           ` <201106200007.47828.rjw@sisk.pl>
2011-06-20  2:01             ` Paul Mundt
     [not found]             ` <20110620020125.GA26125@linux-sh.org>
2011-06-20 22:30               ` Rafael J. Wysocki
     [not found]               ` <201106210030.01922.rjw@sisk.pl>
2011-06-21 11:57                 ` Rafael J. Wysocki
     [not found]                 ` <201106211357.09202.rjw@sisk.pl>
2011-06-21 12:47                   ` Paul Mundt
2011-07-10 11:45         ` [PATCH 8/8] ARM / shmobile: Support for I/O PM domains for SH7372 (v5) Laurent Pinchart
     [not found] ` <201106112231.11269.rjw@sisk.pl>
2011-06-19 22:02   ` [Update][PATCH 4/8] PM / Domains: Support for generic I/O PM domains (v6) Rafael J. Wysocki
     [not found]   ` <201106200002.19377.rjw@sisk.pl>
2011-06-21 17:42     ` Kevin Hilman
     [not found]     ` <874o3jt72c.fsf@ti.com>
2011-06-22  0:07       ` Rafael J. Wysocki
     [not found]       ` <201106220207.01434.rjw@sisk.pl>
2011-06-22 19:51         ` Kevin Hilman
     [not found]         ` <87fwn1lk61.fsf@ti.com>
2011-06-22 21:30           ` Rafael J. Wysocki
     [not found] ` <201106112239.16285.rjw@sisk.pl>
2011-06-11 23:28   ` [Update][PATCH 7/8] PM / Domains: System-wide transitions support for generic domains (v2) Rafael J. Wysocki
2011-06-19 22:06   ` [Update][PATCH 7/8] PM / Domains: System-wide transitions support for generic domains (v3) Rafael J. Wysocki
     [not found]   ` <201106200006.07642.rjw@sisk.pl>
2011-06-20 23:05     ` Rafael J. Wysocki
2011-06-22 21:50     ` Kevin Hilman
     [not found]     ` <8739j1lemc.fsf@ti.com>
2011-06-22 22:16       ` Rafael J. Wysocki
     [not found]       ` <201106230016.46704.rjw@sisk.pl>
2011-06-22 22:18         ` Kevin Hilman
     [not found]         ` <871uyljys6.fsf@ti.com>
2011-06-22 22:22           ` Rafael J. Wysocki
     [not found]           ` <201106230022.56462.rjw@sisk.pl>
2011-06-23 13:57             ` [PATCH] PM / Runtime: Update documentation of interactions with system sleep Rafael J. Wysocki
     [not found]             ` <201106231557.43653.rjw@sisk.pl>
2011-06-24 18:25               ` Kevin Hilman
2011-06-23 14:19         ` [Update][PATCH 7/8] PM / Domains: System-wide transitions support for generic domains (v3) Alan Stern
     [not found] ` <201106112226.07631.rjw@sisk.pl>
2011-06-20 23:37   ` [PATCH 2/8] PM / Domains: Rename struct dev_power_domain to struct dev_pm_domain Kevin Hilman
2011-06-21  0:02 ` [PATCH 0/8] PM / Domains: Support for generic I/O PM domains (v5) Kevin Hilman
     [not found] ` <87boxs3vd3.fsf@ti.com>
2011-06-21 11:06   ` Rafael J. Wysocki
     [not found]   ` <201106211306.26016.rjw@sisk.pl>
2011-06-21 14:47     ` Kevin Hilman
2011-06-25 21:24 ` [PATCH 0/10 v6] PM / Domains: Support for generic I/O PM domains Rafael J. Wysocki
     [not found] ` <201106252324.13454.rjw@sisk.pl>
2011-06-25 21:24   ` [PATCH 1/10 v6] PM / Domains: Rename struct dev_power_domain to struct dev_pm_domain Rafael J. Wysocki
2011-06-25 21:25   ` [PATCH 2/10 v6] PM: subsys_data in struct dev_pm_info need not depend on RM_RUNTIME Rafael J. Wysocki
2011-06-25 21:26   ` [PATCH 3/10 v6] PM / Domains: Support for generic I/O PM domains (v7) Rafael J. Wysocki
2011-06-25 21:27   ` [PATCH 4/10 v6] PM: Introduce generic "noirq" callback routines for subsystems (v2) Rafael J. Wysocki
2011-06-25 21:27   ` Rafael J. Wysocki [this message]
2011-06-25 21:28   ` [PATCH 6/10 v6] PM / Domains: System-wide transitions support for generic domains (v4) Rafael J. Wysocki
2011-06-25 21:29   ` [PATCH 7/10 v6] PM / Domains: Don't stop wakeup devices during system sleep transitions Rafael J. Wysocki
2011-06-25 21:30   ` [PATCH 8/10 v6] PM: Allow the clocks management code to be used during system suspend Rafael J. Wysocki
2011-06-25 21:30   ` [PATCH 9/10 v6] PM: Rename clock management functions Rafael J. Wysocki
2011-06-25 21:31   ` [PATCH 10/10 v6] ARM / shmobile: Support for I/O power domains for SH7372 (v8) Rafael J. Wysocki
     [not found]   ` <201106252331.43354.rjw@sisk.pl>
2011-06-27  4:07     ` Magnus Damm
2011-06-27 19:25       ` Rafael J. Wysocki
     [not found]       ` <201106272125.12700.rjw@sisk.pl>
2011-06-27 23:21         ` Magnus Damm
2011-06-28 10:08           ` Rafael J. Wysocki
     [not found]   ` <201106252328.31882.rjw@sisk.pl>
2011-06-28 23:44     ` [Update][PATCH 6/10] PM / Domains: System-wide transitions support for generic domains (v5) Rafael J. Wysocki
     [not found]     ` <201106290144.01186.rjw@sisk.pl>
2011-07-08  0:29       ` Kevin Hilman
     [not found]       ` <871uy1d380.fsf@ti.com>
2011-07-08  9:24         ` Rafael J. Wysocki
     [not found]   ` <201106252329.24342.rjw@sisk.pl>
2011-06-29 23:50     ` [PATCH 7/10 v6] PM / Domains: Don't stop wakeup devices during system sleep transitions Kevin Hilman
     [not found]     ` <87fwmsnqno.fsf@ti.com>
2011-06-30 19:37       ` Rafael J. Wysocki
     [not found]       ` <201106302137.23801.rjw@sisk.pl>
2011-06-30 22:42         ` Kevin Hilman
     [not found]         ` <878vsjdjpx.fsf@ti.com>
2011-06-30 22:55           ` Rafael J. Wysocki
     [not found]           ` <201107010055.26952.rjw@sisk.pl>
2011-06-30 23:14             ` Kevin Hilman
2011-06-30 23:25             ` Rafael J. Wysocki
     [not found]             ` <87iprmdi9o.fsf@ti.com>
2011-06-30 23:28               ` Rafael J. Wysocki
     [not found]               ` <201107010128.03732.rjw@sisk.pl>
2011-07-01  0:01                 ` Kevin Hilman
2011-07-01  0:24                   ` Rafael J. Wysocki
     [not found]                   ` <201107010224.37609.rjw@sisk.pl>
2011-07-01 14:34                     ` Kevin Hilman
     [not found]   ` <201106252326.23837.rjw@sisk.pl>
2011-06-30  6:14     ` [PATCH 3/10 v6] PM / Domains: Support for generic I/O PM domains (v7) Ming Lei
     [not found]     ` <BANLkTi=tipUrzeKJeQirrNWyE0KMS1+DYw@mail.gmail.com>
2011-06-30 18:58       ` Rafael J. Wysocki
2011-07-01 18:11     ` Kevin Hilman
     [not found]     ` <87tyb5yipq.fsf@ti.com>
2011-07-01 20:03       ` Rafael J. Wysocki
2011-07-01 18:27   ` [PATCH 0/10 v6] PM / Domains: Support for generic I/O PM domains Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201106252327.49552.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox