From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: jean.pihet@newoldbits.com
Cc: markgross@thegnar.org, broonie@opensource.wolfsonmicro.com,
Linux PM mailing list <linux-pm@lists.linux-foundation.org>,
linux-omap@vger.kernel.org, Jean Pihet <j-pihet@ti.com>
Subject: Re: [PATCH 01/13] PM: QoS: rename pm_qos_params files to pm_qos
Date: Fri, 29 Jul 2011 23:57:48 +0200 [thread overview]
Message-ID: <201107292357.48969.rjw@sisk.pl> (raw)
In-Reply-To: <1311841821-10252-2-git-send-email-j-pihet@ti.com>
On Thursday, July 28, 2011, jean.pihet@newoldbits.com wrote:
> From: Jean Pihet <j-pihet@ti.com>
>
> The PM QoS implementation files are better named
> kernel/pm_qos.c and include/linux/pm_qos.h.
>
> Signed-off-by: Jean Pihet <j-pihet@ti.com>
> ---
> arch/arm/mach-msm/clock.c | 2 +-
> drivers/acpi/processor_idle.c | 2 +-
> drivers/cpuidle/cpuidle.c | 2 +-
> drivers/cpuidle/governors/ladder.c | 2 +-
> drivers/cpuidle/governors/menu.c | 2 +-
> drivers/media/video/via-camera.c | 2 +-
> drivers/net/e1000e/netdev.c | 2 +-
> drivers/net/wireless/ipw2x00/ipw2100.c | 2 +-
> drivers/staging/msm/lcdc.c | 2 +-
> drivers/staging/msm/tvenc.c | 2 +-
> include/linux/netdevice.h | 2 +-
> include/linux/pm_qos.h | 38 +++
> include/linux/pm_qos_params.h | 38 ---
> include/sound/pcm.h | 2 +-
> kernel/Makefile | 2 +-
> kernel/pm_qos.c | 481 ++++++++++++++++++++++++++++++++
> kernel/pm_qos_params.c | 481 --------------------------------
> net/mac80211/main.c | 2 +-
> net/mac80211/mlme.c | 2 +-
> net/mac80211/scan.c | 2 +-
> sound/core/pcm_native.c | 2 +-
> 21 files changed, 536 insertions(+), 536 deletions(-)
> create mode 100644 include/linux/pm_qos.h
> delete mode 100644 include/linux/pm_qos_params.h
That I agree with.
> create mode 100644 kernel/pm_qos.c
> delete mode 100644 kernel/pm_qos_params.c
As I said, please move that file to kernel/power and call it qos.c.
That said the device interface should be located in drivers/base/power
to follow our current conventions.
Thanks,
Rafael
next prev parent reply other threads:[~2011-07-29 21:57 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1311841821-10252-1-git-send-email-j-pihet@ti.com>
2011-07-28 8:30 ` [PATCH 01/13] PM: QoS: rename pm_qos_params files to pm_qos jean.pihet
2011-07-28 8:30 ` [PATCH 02/13] PM: add a per-device wake-up latency constraints plist jean.pihet
2011-07-28 8:30 ` [PATCH 03/13] PM: QoS: extend the in-kernel API with per-device latency constraints jean.pihet
2011-07-28 8:30 ` [PATCH 04/13] PM: QoS: implement the " jean.pihet
2011-07-28 8:30 ` [PATCH 05/13] PM: QoS: support the dynamic insertion and removal of devices jean.pihet
2011-07-28 8:30 ` [PATCH 06/13] OMAP PM: create a PM layer plugin for per-device constraints jean.pihet
2011-07-28 8:30 ` [PATCH 07/13] OMAP PM: early init of the pwrdms states jean.pihet
2011-07-28 8:30 ` [PATCH 08/13] OMAP2+: powerdomain: control power domains next state jean.pihet
2011-07-28 8:30 ` [PATCH 09/13] OMAP3: powerdomain data: add wake-up latency figures jean.pihet
2011-07-28 8:30 ` [PATCH 10/13] OMAP4: " jean.pihet
2011-07-28 8:30 ` [PATCH 11/13] OMAP2+: omap_hwmod: manage the wake-up latency constraints jean.pihet
2011-07-28 8:30 ` [PATCH 12/13] OMAP: PM CONSTRAINTS: implement the devices " jean.pihet
2011-07-28 8:30 ` [PATCH 13/13] OMAP2+: cpuidle only influences the MPU state jean.pihet
2011-07-28 13:14 ` [RFC/PATCH v3 00/13] PM QoS: add a per-device latency constraints class mark gross
2011-07-29 8:37 ` Jean Pihet
[not found] ` <CAORVsuVoJ5-1hx2+6+gCuuWDd9A9h_RTS=U1228BM7EYiG=gxA@mail.gmail.com>
2011-07-29 14:24 ` mark gross
[not found] ` <20110729142459.GA5509@gvim.org>
2011-07-29 21:46 ` Rafael J. Wysocki
[not found] ` <201107292346.22211.rjw@sisk.pl>
2011-07-31 17:38 ` mark gross
[not found] ` <1311841821-10252-9-git-send-email-j-pihet@ti.com>
2011-07-29 7:59 ` [PATCH 08/13] OMAP2+: powerdomain: control power domains next state Todd Poynor
[not found] ` <20110729075942.GA26959@google.com>
2011-07-29 8:47 ` Jean Pihet
[not found] ` <CAORVsuV68JhpV5XzXNV3Z9xxRUBbgDen7NDRG+h=in7-ZL=JhQ@mail.gmail.com>
2011-07-29 18:00 ` Todd Poynor
[not found] ` <20110729180047.GA14228@google.com>
2011-08-11 15:09 ` Jean Pihet
[not found] ` <1311841821-10252-8-git-send-email-j-pihet@ti.com>
2011-07-29 8:08 ` [PATCH 07/13] OMAP PM: early init of the pwrdms states Todd Poynor
[not found] ` <20110729080820.GB26959@google.com>
2011-07-29 8:50 ` Jean Pihet
[not found] ` <CAORVsuUovg7px5SGC+mt7CoDcXZ8r2d09obkXqSp=g44U1G9EQ@mail.gmail.com>
2011-08-02 8:57 ` Jean Pihet
[not found] ` <CAORVsuVHAvQRxPz8cCfQ0L1jN1nT5aNDVZ7fpuajAUosyvumeA@mail.gmail.com>
2011-08-11 15:12 ` Jean Pihet
2011-07-29 21:25 ` [RFC/PATCH v3 00/13] PM QoS: add a per-device latency constraints class Rafael J. Wysocki
[not found] ` <1311841821-10252-2-git-send-email-j-pihet@ti.com>
2011-07-29 21:57 ` Rafael J. Wysocki [this message]
2011-08-02 9:31 ` [PATCH 01/13] PM: QoS: rename pm_qos_params files to pm_qos Jean Pihet
2011-08-02 9:47 ` Rafael J. Wysocki
[not found] ` <1311841821-10252-3-git-send-email-j-pihet@ti.com>
2011-07-29 21:58 ` [PATCH 02/13] PM: add a per-device wake-up latency constraints plist Rafael J. Wysocki
[not found] ` <1311841821-10252-4-git-send-email-j-pihet@ti.com>
2011-07-29 22:55 ` [PATCH 03/13] PM: QoS: extend the in-kernel API with per-device latency constraints Rafael J. Wysocki
[not found] ` <201107300055.49468.rjw@sisk.pl>
2011-08-02 9:41 ` Jean Pihet
[not found] ` <CAORVsuVY63VYGEB7CM50UzJS3wLt+jZn5U6S9X+277GB_ETV1g@mail.gmail.com>
2011-08-02 21:02 ` Rafael J. Wysocki
2011-08-02 18:01 ` Kevin Hilman
[not found] ` <1311841821-10252-5-git-send-email-j-pihet@ti.com>
2011-07-30 22:30 ` [PATCH 04/13] PM: QoS: implement the " Rafael J. Wysocki
[not found] ` <201107310030.29286.rjw@sisk.pl>
2011-08-02 10:05 ` Jean Pihet
[not found] ` <CAORVsuXzn8wGZsyxUcAN7stjbU4Kshwdg2CW06w17Y5O7oJVsA@mail.gmail.com>
2011-08-02 21:13 ` Rafael J. Wysocki
[not found] ` <1311841821-10252-6-git-send-email-j-pihet@ti.com>
2011-07-30 22:38 ` [PATCH 05/13] PM: QoS: support the dynamic insertion and removal of devices Rafael J. Wysocki
[not found] ` <201107310038.30710.rjw@sisk.pl>
2011-08-02 10:07 ` Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107292357.48969.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=j-pihet@ti.com \
--cc=jean.pihet@newoldbits.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=markgross@thegnar.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox