linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: MyungJoo Ham <myungjoo.ham@gmail.com>
Cc: linux-pm@lists.linux-foundation.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH v2] Add regulator driver for the bq2407x family of charger ICs.
Date: Thu, 25 Aug 2011 10:51:53 +0200	[thread overview]
Message-ID: <201108251051.53852.heiko@sntech.de> (raw)
In-Reply-To: <CAJ0PZbQRGCHAQ1HxDmbf6uN8iz3CCcqjOVRtc63Cjn17EXak1A@mail.gmail.com>

Hi MyungJoo

Am Donnerstag, 25. August 2011, 08:55:29 schrieb MyungJoo Ham:
> On Thu, Aug 25, 2011 at 3:48 AM, Heiko Stübner <heiko@sntech.de> wrote:
> > This driver controls a TI bq2407x charger attached via GPIOs.
> > The provided current regulator can enable/disable charging and
> > select between 100 mA, 500 mA and a machine specific current limit.
> > 
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> 
> This looks like a bq24022 driver + max-current-mode ("USB standby"
> seems not implemented in the driver). Wouldn't it be possible to patch
> bq24022 driver so that the bq24022 driver becomes compatible with this
> bq2407x?
> 
> 2407x's EN1 = 24022's iset2
> 2407x's nce = 24022's nce
> 
> I think you may simply let the driver ignore EN2 (and max-current
> mode) if the supplied EN2 in pdata is NULL, then, the driver will be
> compatible for both.

Thanks for adding a new perspective on this. The way you put it, it seems 
quite easy to do it this way and integrate it into the bq24022 driver.

So I will give it shot this evening and will see were it leads me.

Thanks
Heiko

      reply	other threads:[~2011-08-25  8:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-20 20:24 [PATCH] Add regulator driver for the bq2407x family of charger ICs Heiko Stübner
2011-08-23 11:50 ` Mark Brown
2011-08-23 20:15   ` Heiko Stübner
2011-08-24  9:07     ` Mark Brown
2011-08-24 18:48       ` [PATCH v2] " Heiko Stübner
2011-08-25  6:55         ` MyungJoo Ham
2011-08-25  8:51           ` Heiko Stübner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108251051.53852.heiko@sntech.de \
    --to=heiko@sntech.de \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=lrg@ti.com \
    --cc=myungjoo.ham@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).