From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-pm@lists.linux-foundation.org, Liam Girdwood <lrg@ti.com>,
Philipp Zabel <philipp.zabel@gmail.com>
Subject: Re: [PATCH 1/3] bq24022: Evaluate returns of gpio_direction_output-calls
Date: Mon, 29 Aug 2011 10:16:50 +0100 [thread overview]
Message-ID: <20110829091649.GB9477@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <201108281508.31412.heiko@sntech.de>
On Sun, Aug 28, 2011 at 03:08:30PM +0200, Heiko Stübner wrote:
> ret = gpio_direction_output(pdata->gpio_iset2, 0);
> + if (ret) {
> + dev_dbg(&pdev->dev, "couldn't set ISET2 GPIO: %d\n",
> + pdata->gpio_iset2);
> + goto err_reg;
> + }
> ret = gpio_direction_output(pdata->gpio_nce, 1);
> + if (ret) {
> + dev_dbg(&pdev->dev, "couldn't set nCE GPIO: %d\n",
> + pdata->gpio_nce);
> + goto err_reg;
> + }
If these are fatal errors the log messages shouldn't be dev_dbg() but
should instead be something that will be displayed by default.
next prev parent reply other threads:[~2011-08-29 9:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-28 13:07 [PATCH 0/3] bq24022: Add support for bq2407x family Heiko Stübner
2011-08-28 13:08 ` [PATCH 1/3] bq24022: Evaluate returns of gpio_direction_output-calls Heiko Stübner
2011-08-29 9:16 ` Mark Brown [this message]
2011-08-28 13:09 ` [PATCH 2/3] bq24022: Keep track of gpio states Heiko Stübner
2011-08-29 9:18 ` Mark Brown
2011-08-28 13:10 ` [PATCH 3/3] bq24022: Add support for the bq2407x family Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110829091649.GB9477@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=heiko@sntech.de \
--cc=linux-pm@lists.linux-foundation.org \
--cc=lrg@ti.com \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).