linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@ti.com>
Cc: linux-pm@lists.linux-foundation.org,
	Philipp Zabel <philipp.zabel@gmail.com>
Subject: [PATCH 2/4] bq24022: Use dev_err instead of dev_dbg for error messages
Date: Mon, 29 Aug 2011 17:57:29 +0200	[thread overview]
Message-ID: <201108291757.30189.heiko@sntech.de> (raw)
In-Reply-To: <201108291755.15701.heiko@sntech.de>

This makes error messages visible to the user,
so he/she can eventually fix them.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 drivers/regulator/bq24022.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/bq24022.c b/drivers/regulator/bq24022.c
index 56627d7..7bd906c 100644
--- a/drivers/regulator/bq24022.c
+++ b/drivers/regulator/bq24022.c
@@ -93,13 +93,13 @@ static int __init bq24022_probe(struct platform_device *pdev)
 
 	ret = gpio_request(pdata->gpio_nce, "ncharge_en");
 	if (ret) {
-		dev_dbg(&pdev->dev, "couldn't request nCE GPIO: %d\n",
+		dev_err(&pdev->dev, "couldn't request nCE GPIO: %d\n",
 			pdata->gpio_nce);
 		goto err_ce;
 	}
 	ret = gpio_request(pdata->gpio_iset2, "charge_mode");
 	if (ret) {
-		dev_dbg(&pdev->dev, "couldn't request ISET2 GPIO: %d\n",
+		dev_err(&pdev->dev, "couldn't request ISET2 GPIO: %d\n",
 			pdata->gpio_iset2);
 		goto err_iset2;
 	}
@@ -119,7 +119,7 @@ static int __init bq24022_probe(struct platform_device *pdev)
 	bq24022 = regulator_register(&bq24022_desc, &pdev->dev,
 				     pdata->init_data, pdata);
 	if (IS_ERR(bq24022)) {
-		dev_dbg(&pdev->dev, "couldn't register regulator\n");
+		dev_err(&pdev->dev, "couldn't register regulator\n");
 		ret = PTR_ERR(bq24022);
 		goto err_reg;
 	}
-- 
1.7.2.3

  parent reply	other threads:[~2011-08-29 15:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-29 15:55 [PATCH v2 0/4] bq24022: Add support for bq2407x family Heiko Stübner
2011-08-29 15:56 ` [PATCH v2 1/4] bq24022: Evaluate returns of gpio_direction_output-calls Heiko Stübner
2011-08-30 10:39   ` Mark Brown
2011-08-29 15:57 ` Heiko Stübner [this message]
2011-08-30 10:40   ` [PATCH 2/4] bq24022: Use dev_err instead of dev_dbg for error messages Mark Brown
2011-08-29 15:58 ` [PATCH 3/4] bq24022: Keep track of gpio states Heiko Stübner
2011-08-29 15:59 ` [PATCH v2 4/4] bq24022: Add support for the bq2407x family Heiko Stübner
2011-08-30 10:52   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108291757.30189.heiko@sntech.de \
    --to=heiko@sntech.de \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=lrg@ti.com \
    --cc=philipp.zabel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).