From: mark gross <markgross@thegnar.org>
To: ananaza@iki.fi
Cc: linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH 0/6] RFC: CPU frequency min/max as PM QoS params
Date: Fri, 6 Jan 2012 18:57:26 -0800 [thread overview]
Message-ID: <20120107025726.GA3119@mgross-G62> (raw)
In-Reply-To: <20120106.213839.2153351629911262951.apm@brigitte.kvy.fi>
On Fri, Jan 06, 2012 at 09:38:39PM +0200, Antti P Miettinen wrote:
> [seems that posting via gmane is broken - resending (heehee - I do
> resent the gmane problem :) manually via mail - sorry if you get
> duplicates]
FWIW I've been having odd email behavior WRT linux-pm. I'm not sure if
its my .procmailrc file or something else.
> mark gross <markgross@thegnar.org> writes:
> > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > index 987a165..4cbd58b 100644
> > --- a/drivers/cpufreq/cpufreq.c
> > +++ b/drivers/cpufreq/cpufreq.c
> [..]
> > +
> > + if (policy->min < pm_qos_request(PM_QOS_CPU_THROUGHPUT))
> > + policy->min = pm_qos_request(PM_QOS_CPU_THROUGHPUT);
> >
>
> Consider the following sequence
>
> - say original min is 100MHz
> - PM QoS requests 1GHz minimum
> - user requests 500MHz minimum via sysfs
> - PM QoS request is canceled
>
> After this the policy->min will be 1GHz. I'm not really happy with the
> min/max save/restore etc but something is needed to enable restoring the
> policy min/max when PM QoS constraints dissappear.
you are right. If CPUFREQ is to be QoS aware we need to have it save
the request from user mode and compute the max between the user request
and the pm_qos constraint.
--mark
next prev parent reply other threads:[~2012-01-07 2:57 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 0:36 [PATCH 0/6] RFC: CPU frequency min/max as PM QoS params Antti P Miettinen
2012-01-06 0:36 ` [PATCH 1/6] PM QoS: Simplify PM QoS expansion/merge Antti P Miettinen
2012-01-06 15:24 ` mark gross
2012-01-08 23:03 ` Rafael J. Wysocki
2012-01-06 0:36 ` [PATCH 2/6] PM QoS: Add CPU frequency min/max as PM QoS params Antti P Miettinen
2012-01-06 15:30 ` mark gross
2012-01-06 19:32 ` Antti P Miettinen
2012-01-07 3:47 ` mark gross
2012-01-07 8:54 ` Antti P Miettinen
2012-01-06 0:36 ` [PATCH 3/6] cpufreq: Export user_policy min/max Antti P Miettinen
2012-01-06 15:33 ` mark gross
2012-01-06 19:29 ` Antti P Miettinen
2012-01-07 3:53 ` mark gross
2012-01-07 8:47 ` Antti P Miettinen
2012-01-09 14:18 ` mark gross
2012-01-06 0:36 ` [PATCH 4/6] cpufreq: Preserve sysfs min/max request Antti P Miettinen
2012-01-06 0:36 ` [PATCH 5/6] cpufreq: Enforce PM QoS min/max limits Antti P Miettinen
2012-01-06 15:38 ` mark gross
2012-01-06 0:36 ` [PATCH 6/6] input: CPU frequency booster Antti P Miettinen
2012-01-06 15:40 ` mark gross
2012-01-06 15:18 ` [PATCH 0/6] RFC: CPU frequency min/max as PM QoS params mark gross
2012-01-06 15:46 ` mark gross
2012-01-06 19:38 ` Antti P Miettinen
2012-01-07 2:57 ` mark gross [this message]
2012-01-06 18:27 ` mark gross
2012-01-08 22:59 ` Rafael J. Wysocki
2012-01-09 14:23 ` mark gross
2012-01-09 21:27 ` Rafael J. Wysocki
2012-01-09 21:57 ` Antti P Miettinen
2012-01-10 20:44 ` Rafael J. Wysocki
2012-01-11 7:26 ` Antti P Miettinen
2012-01-11 23:15 ` Rafael J. Wysocki
2012-01-12 8:37 ` Antti P Miettinen
2012-01-12 23:55 ` Rafael J. Wysocki
2012-01-10 4:50 ` mark gross
2012-01-10 20:46 ` Rafael J. Wysocki
2012-01-10 21:02 ` Jean Pihet
2012-01-11 7:32 ` Antti P Miettinen
2012-01-11 23:00 ` Rafael J. Wysocki
2012-01-12 8:43 ` Antti P Miettinen
2012-01-13 4:37 ` mark gross
2012-01-12 3:06 ` mark gross
2012-01-12 23:52 ` Rafael J. Wysocki
2012-01-12 3:01 ` mark gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120107025726.GA3119@mgross-G62 \
--to=markgross@thegnar.org \
--cc=ananaza@iki.fi \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).