From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Viresh Kumar <viresh.kumar@st.com>
Cc: len.brown@intel.com, Vipul Kumar SAMAR <vipulkumar.samar@st.com>,
Bhupesh SHARMA <bhupesh.sharma@st.com>,
Pratyush ANAND <pratyush.anand@st.com>,
Armando VISCONTI <armando.visconti@st.com>,
Mirko GARDI <mirko.gardi@st.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Vipin KUMAR <vipin.kumar@st.com>,
Shiraz HASHIM <shiraz.hashim@st.com>,
Amit VIRDI <amit.virdi@st.com>,
Rajeev KUMAR <rajeev-dlh.kumar@st.com>,
deepak sikri <deepak.sikri@st.com>,
"linux-pm@lists.linux-foundation.org"
<linux-pm@lists.linux-foundation.org>,
Vincenzo FRASCINO <Vincenzo.FRASCINO@st.com>
Subject: Re: Query: When will drv->poweroff() called
Date: Mon, 6 Feb 2012 13:07:40 +0100 [thread overview]
Message-ID: <201202061307.40628.rjw@sisk.pl> (raw)
In-Reply-To: <4F2F6B40.6070308@st.com>
Hi,
On Monday, February 06, 2012, Viresh Kumar wrote:
>
> Hi Guys,
>
> Sorry for asking this silly question, but i couldn't locate much
> help for it in documentation, so asking it.
>
> We were testing hibernation for SPEAr13xx SoC family, based on
> ARM Cortex a9.
>
> I observed that poweroff() callback of individual drivers are not
> getting called at all, while we test hibernate.
They should be called in the last phase of hibernation, after the image
has been created and the system is going for "power off" (hance the
callback name).
> I tried to go through the code to see what happened. It looked like
> there should be call to hibernation_set_ops() for platforms that are
> willing to get a call to poweroff() for their drivers.
That's correct. The ->poweroff() callbacks are only executed if
hibernation_mode is equal to HIBERNATION_PLATFORM, which is not the
default.
> Otherwise shutdown of the busses gets called, which is a completely
> different path.
>
> There are many drivers today, that are registering poweroff() from dev_pm_ops
> but are not doing bus specific shutdown stuff.
>
> Even i tried to look for hibernation_set_ops() in kernel, and only acpi
> code is calling it.
That's correct too.
> I didn't understood how other ARM Sub-Arch's are handling this.
Well, they are supposed to call hibernation_set_ops() and set the operations
appropriately. Those operations may be empty routines if they don't need
to do anything, but they have to be defined.
Thanks,
Rafael
next prev parent reply other threads:[~2012-02-06 12:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 5:55 Query: When will drv->poweroff() called Viresh Kumar
2012-02-06 12:07 ` Rafael J. Wysocki [this message]
2012-02-07 4:19 ` Viresh Kumar
2012-02-16 15:16 ` viresh kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202061307.40628.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=Vincenzo.FRASCINO@st.com \
--cc=amit.virdi@st.com \
--cc=armando.visconti@st.com \
--cc=bhupesh.sharma@st.com \
--cc=deepak.sikri@st.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mirko.gardi@st.com \
--cc=pratyush.anand@st.com \
--cc=rajeev-dlh.kumar@st.com \
--cc=shiraz.hashim@st.com \
--cc=vipin.kumar@st.com \
--cc=vipulkumar.samar@st.com \
--cc=viresh.kumar@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).