From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH] thermal: Fix for setting the thermal zone mode to enable/disable Date: Wed, 21 Mar 2012 16:18:51 +0100 Message-ID: <20120321161851.2f072204@endymion.delvare> References: <1332328201-21191-1-git-send-email-amit.kachhap@linaro.org> <20120321151357.53fb86e4@endymion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org To: Eric Paris Cc: Amit Daniel Kachhap , linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, lenb@kernel.org, linaro-dev@lists.linaro.org, patches@linaro.org List-Id: linux-pm@vger.kernel.org Hi Eric, On Wed, 21 Mar 2012 10:47:52 -0400, Eric Paris wrote: > On Wed, Mar 21, 2012 at 10:13 AM, Jean Delvare wrote: > > Note that a quick grep suggests that drivers/misc/ad525x_dpot.c, > > security/selinux/hooks.c and arch/m68k/sun3/prom/console.c suffer from > > the same issue, if you want to fix them too. > > I do see that we use sizeof() for strings in the selinux code, but I > don't see a place that it is a bug. If you see a bug let me know and > I'd be happy to fix it! My suspect is in sb_finish_set_opts(): if (strncmp(sb->s_type->name, "sysfs", sizeof("sysfs")) == 0) If sb->s_type->name is exactly "sysfs", it will work, but if it only starts with "sysfs" it won't. And if only exact matches are expected, then strncmp is overkill and strcmp should be used instead. Note that I don't know anything about the code so I might as well be totally wrong. -- Jean Delvare