From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH] thermal: Fix for setting the thermal zone mode to enable/disable Date: Wed, 21 Mar 2012 16:27:57 +0100 Message-ID: <20120321162757.527f87e2@endymion.delvare> References: <1332328201-21191-1-git-send-email-amit.kachhap@linaro.org> <20120321151357.53fb86e4@endymion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Geert Uytterhoeven Cc: linaro-dev@lists.linaro.org, patches@linaro.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@lists.linux-foundation.org List-Id: linux-pm@vger.kernel.org On Wed, 21 Mar 2012 16:14:46 +0100, Geert Uytterhoeven wrote: > On Wed, Mar 21, 2012 at 15:13, Jean Delvare wrote: > > On Wed, 21 Mar 2012 16:40:01 +0530, Amit Daniel Kachhap wrote: > >> Basically without this patch changing the mode of thermal zone > >> is not possible as wrong string size is passed to strncmp. > > > > Actually it is possible, > > $ echo -n disabled > mode > > works fine. But it fails without the -n, your patch would fix that. > > Now it ignores any extra characters. Are they always newlines? > > Now "echo -n disabledx > mode" will also "succeed". I guess this is considered good enough in practice, although I also don't like this use of strncmp. I'd prefer \n to be properly converted to \0 (by the sysfs layer itself) so that strict string comparisons can be done. I don't have the time to push this though, sorry. -- Jean Delvare