From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH] PCI: add NO_D3_DURING_SLEEP flag and revert 151b61284776be2 Date: Wed, 13 Jun 2012 22:04:43 +0200 Message-ID: <201206132204.43622.rjw@sisk.pl> References: <201206131122.36198.rjw@sisk.pl> <20120613152701.GA28116@kroah.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20120613152701.GA28116@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Greg KH Cc: =?iso-8859-1?q?D=E2niel_Fraga?= , USB list , Steven Rostedt , Andrey Rahmatullin , "Oleksij Rempel (fishor)" , linux-pm@lists.linux-foundation.org List-Id: linux-pm@vger.kernel.org On Wednesday, June 13, 2012, Greg KH wrote: > On Wed, Jun 13, 2012 at 11:20:19AM -0400, Alan Stern wrote: > > This patch (as1558) fixes a problem affecting several ASUS computers: > > The machine crashes or corrupts memory when going into suspend if the > > ehci-hcd driver is bound to any controllers. Users have been forced > > to unbind or unload ehci-hcd before putting their systems to sleep. > >=20 > > After extensive testing, it was determined that the machines don't > > like going into suspend when any EHCI controllers are in the PCI D3 > > power state. Presumably this is a firmware bug, but there's nothing > > we can do about it except to avoid putting the controllers in D3 > > during system sleep. > >=20 > > The patch adds a new flag to indicate whether the problem is present, > > and avoids changing the controller's power state if the flag is set. > > Runtime suspend is unaffected; this matters only for system suspend. > > However as a side effect, the controller will not respond to remote > > wakeup requests while the system is asleep. Hence USB wakeup is not > > functional -- but of course, this is already true in the current state > > of affairs. > >=20 > > A similar patch has already been applied as commit > > 151b61284776be2d6f02d48c23c3625678960b97 (USB: EHCI: fix crash during > > suspend on ASUS computers). The patch supersedes that one and reverts > > it. There are two differences: > >=20 > > The old patch added the flag at the USB level; this patch > > adds it at the PCI level. > >=20 > > The old patch applied to all chipsets with the same vendor, > > subsystem vendor, and product IDs; this patch makes an > > exception for a known-good system (based on DMI information). > >=20 > > Signed-off-by: Alan Stern > > Tested-by: D=E2niel Fraga > > Tested-by: Andrey Rahmatullin > > Tested-by: Steven Rostedt > > CC: Greg KH > > CC: > >=20 > > --- > >=20 > > Greg, do you mind if this goes in through Rafael's tree? >=20 > Not at all, but I can also take it. >=20 > Rafael, if you want to take it, please add: >=20 > Acked-by: Greg Kroah-Hartman >=20 > to it, or let me know, and I can take this through my tree. Please take it, if that's not a problem, I don't have any other patches for 3.5 pending. And please add: Reviewed-by: Rafael J. Wysocki to it. Thanks, Rafael