From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Zhang, Rui" <rui.zhang@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-pm <linux-pm@lists.linux-foundation.org>,
linux-i2c <linux-i2c@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"Len, Brown" <lenb@kernel.org>, "Rafael J. Wysocki" <rjw@sisk.pl>,
Grant Likely <grant.likely@secretlab.ca>,
Dirk Brandewie <dirk.brandewie@gmail.com>
Subject: Re: [RFC PATCH 1/6] Introduce acpi_match_device_id().
Date: Mon, 1 Oct 2012 09:37:53 +0300 [thread overview]
Message-ID: <20121001063753.GE15548@intel.com> (raw)
In-Reply-To: <744357E9AAD1214791ACBA4B0B90926322C156@SHSMSX101.ccr.corp.intel.com>
On Sat, Sep 29, 2012 at 01:31:52PM +0000, Zhang, Rui wrote:
>
> > > +{
> > > + acpi_handle handle = DEVICE_ACPI_HANDLE(dev);
> >
> > If the device is not bound to an ACPI handle this will return NULL. And
> > I don't see you doing that in this series meaning that..
> >
>
>
> You're right, I should set pdev->archdata.acpi_handle to the I2C
> controller in i2c_root.c.
There already is an API for that - check drivers/acpi/glue.c.
next prev parent reply other threads:[~2012-10-01 6:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 7:38 [RFC PATCH 1/6] Introduce acpi_match_device_id() Zhang Rui
2012-09-28 14:13 ` Mika Westerberg
[not found] ` <20120928141347.GC15548-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2012-09-29 13:31 ` Zhang, Rui
2012-10-01 6:37 ` Mika Westerberg [this message]
[not found] ` <20121001063753.GE15548-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2012-10-01 13:56 ` Zhang, Rui
2012-10-02 6:10 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121001063753.GE15548@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=dirk.brandewie@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).