From: Fengguang Wu <fengguang.wu@intel.com>
To: Youquan Song <youquan.song@intel.com>
Cc: yuanhan.liu@linux.intel.com, rjw@sisk.pl,
Rik van Riel <riel@redhat.com>,
linux-pm@vger.kernel.org,
Youquan Song <youquan.song@linux.intel.com>
Subject: Re: [PATCH] cpuidle: fix warning when compile
Date: Tue, 23 Oct 2012 22:42:49 +0800 [thread overview]
Message-ID: <20121023144249.GA24862@localhost> (raw)
In-Reply-To: <1351046728-10965-1-git-send-email-youquan.song@intel.com>
On Tue, Oct 23, 2012 at 10:45:28PM -0400, Youquan Song wrote:
> Fix the warning complain when compile the kernel.
>
> drivers/cpuidle/governors/menu.c: In function 'get_typical_interval':
> drivers/cpuidle/governors/menu.c:268:2: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> drivers/cpuidle/governors/menu.c:277:2: warning: comparison of distinct pointer types lacks a cast [enabled by default]
>
> Signed-off-by: Youquan Song <youquan.song@intel.com>
Tested-by: Fengguang Wu <wfg@linux.intel.com>
> ---
> drivers/cpuidle/governors/menu.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c
> index 26d5667..2efee27 100644
> --- a/drivers/cpuidle/governors/menu.c
> +++ b/drivers/cpuidle/governors/menu.c
> @@ -248,7 +248,7 @@ static enum hrtimer_restart menu_hrtimer_notify(struct hrtimer *hrtimer)
> static u32 get_typical_interval(struct menu_device *data)
> {
> int i = 0, divisor = 0;
> - int64_t max = 0, avg = 0, stddev = 0;
> + uint64_t max = 0, avg = 0, stddev = 0;
> int64_t thresh = LLONG_MAX; /* Discard outliers above this value. */
> unsigned int ret = 0;
>
> --
> 1.7.7.4
next prev parent reply other threads:[~2012-10-23 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 2:45 [PATCH] cpuidle: fix warning when compile Youquan Song
2012-10-23 14:42 ` Fengguang Wu [this message]
2012-10-24 0:28 ` Rafael J. Wysocki
2012-10-24 2:14 ` Song, Youquan
2012-10-24 21:03 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121023144249.GA24862@localhost \
--to=fengguang.wu@intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=riel@redhat.com \
--cc=rjw@sisk.pl \
--cc=youquan.song@intel.com \
--cc=youquan.song@linux.intel.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox