Re: [for-next PATCH] PM / devfreq: Add sysfs node to expose available frequencies

Nishanth Menon
2012-10-26T00:03:27Z

On 01:56-20121026, Rafael J. Wysocki wrote:
> On Thursday, October 25, 2012 06:32:43 PM Nishanth Menon wrote:
[..]
> > +static ssize_t show_available_freqs(struct device *d,
> > + struct device_attribute *attr,
> > + char *buf)
> > +{
> > + struct devfreq *df = to_devfreq(d);
> > + struct device *dev = df->dev.parent;
> > + struct opp *opp;
> > + ssize_t count = 0;
> > + unsigned long freq = 0;
> > +
> > + rcu_read_lock();
> > + do {
> > + opp = opp_find_freq_ceil(dev, &freq);
> > + if (IS_ERR(opp))
> > + break;
> > +
> > + count += sprintf(&buf[count], "%lu ", freq);
> > + freq++;
> > + } while (1);
> > + rcu_read_unlock();
> > + count += sprintf(&buf[count], "\n");
>
> Care to avoid printing the tailing space?
count -= count ? 1 : 0;
count += sprintf(&buf[count], "\n");
should take care of empty list and the trailing space. Sounds reasonable?

--
Regards,
Nishanth Menon