From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v8 05/11] libata-eh: allow defer in ata_exec_internal Date: Wed, 31 Oct 2012 14:52:13 -0700 Message-ID: <20121031215213.GD2945@htj.dyndns.org> References: <1351501298-3716-1-git-send-email-aaron.lu@intel.com> <1351501298-3716-6-git-send-email-aaron.lu@intel.com> <20121029152051.GK5171@htj.dyndns.org> <508F42C0.8070807@intel.com> <20121030030144.GG4066@htj.dyndns.org> <508F44E1.3000801@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <508F44E1.3000801@intel.com> Sender: linux-scsi-owner@vger.kernel.org To: Aaron Lu Cc: Jeff Garzik , "Rafael J. Wysocki" , James Bottomley , Alan Stern , Oliver Neukum , Jeff Wu , Aaron Lu , Shane Huang , linux-ide@vger.kernel.org, linux-pm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-acpi@vger.kernel.org List-Id: linux-pm@vger.kernel.org Hello, On Tue, Oct 30, 2012 at 11:09:21AM +0800, Aaron Lu wrote: > I'm not aware of a place to store such ODD specific information when > probing the device. You can always add some fields. :) > I'm currently storing the loading mech type in structure zpodd, which > gets created after the corresponding SCSI device gets created in > ata_scsi_scan_host, so at the probe time, the zpodd structure does not > exist yet. And the reason I create the zpodd sturcture this late is > that, it is only created when the ODD together the platform is ZPODD > capable, and to find out if this platform is ZPODD capbale, ACPI binding > has to occur first, and ACPI binding happens when SCSI device is added > to the device tree. Hmm... I see. Which ACPI binding is it? The ATA ACPI binding happens during probing. It's a different one, I presume? Thanks. -- tejun