From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: "rjw@sisk.pl" <rjw@sisk.pl>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"pdeschrijver@nvidia.com" <pdeschrijver@nvidia.com>,
"linaro-dev@lists.linaro.org" <linaro-dev@lists.linaro.org>
Subject: Re: [PATCH V3 0/4] cpuidle : multiple drivers support
Date: Fri, 2 Nov 2012 13:19:50 +0000 [thread overview]
Message-ID: <20121102131950.GA4432@e102568-lin.cambridge.arm.com> (raw)
In-Reply-To: <1351701888-19963-1-git-send-email-daniel.lezcano@linaro.org>
On Wed, Oct 31, 2012 at 04:44:44PM +0000, Daniel Lezcano wrote:
> The discussion about having different cpus on the system with
> different latencies bring us to a first attemp by adding a
> pointer in the cpuidle_device to the states array.
>
> But as Rafael suggested, it would make more sense to create a
> driver per cpu [1].
>
> This patch adds support for multiple cpuidle drivers.
>
> It creates a per cpu cpuidle driver pointer.
>
> In order to not break the different drivers, the function cpuidle_register_driver
> assign for each cpu, the driver.
>
> The multiple driver support is optional and if it is not set, the cpuide driver
> core code remains the same (except some code reorganisation).
>
> I did the following tests compiled, booted, tested without/with CONFIG_CPU_IDLE,
> with/without CONFIG_CPU_IDLE_MULTIPLE_DRIVERS.
>
> Tested on Core2 Duo T9500 with acpi_idle [and intel_idle]
> Tested on ARM Dual Cortex-A9 U8500 (aka Snowball)
>
> V1 tested on Tegra3 and Vexpress TC2
V3 tested on TC2, hence, on the whole series
Tested-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>
> [1] http://www.spinics.net/lists/linux-acpi/msg37921.html
>
> Changelog:
>
> V2:
> * fixed sysfs output : /sys/devices/system/cpu/cpu[0-9]/driver/name
> * fixed ifdefs in driver.c
> * fixed register_driver function loop when unregistering
> * removed WARN under spinlock
> * fixed changelog for patch [2/4]
> * changed cpuidle_get_cpu_driver function parameter
> * removed cpuidle_for_each_driver function
> * replaced smp_processor_id() by get_cpu/put_cpu
>
> V3:
> * refreshed patchset
>
> Daniel Lezcano (4):
> cpuidle: move driver's refcount to cpuidle
> cpuidle: move driver checking within the lock section
> cpuidle: prepare the driver core to be multi drivers aware
> cpuidle: support multiple drivers
>
> drivers/cpuidle/Kconfig | 9 ++
> drivers/cpuidle/cpuidle.c | 36 +++++---
> drivers/cpuidle/cpuidle.h | 4 +-
> drivers/cpuidle/driver.c | 209 ++++++++++++++++++++++++++++++++++++++------
> drivers/cpuidle/sysfs.c | 174 ++++++++++++++++++++++++++++++++++++--
> include/linux/cpuidle.h | 8 ++-
> 6 files changed, 388 insertions(+), 52 deletions(-)
>
> --
> 1.7.5.4
>
>
next prev parent reply other threads:[~2012-11-02 13:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 16:44 [PATCH V3 0/4] cpuidle : multiple drivers support Daniel Lezcano
2012-10-31 16:44 ` [PATCH V3 1/4] cpuidle: move driver's refcount to cpuidle Daniel Lezcano
2012-10-31 16:44 ` [PATCH V3 2/4] cpuidle: move driver checking within the lock section Daniel Lezcano
[not found] ` <1351701888-19963-1-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-10-31 16:44 ` [PATCH V3 3/4] cpuidle: prepare the driver core to be multi drivers aware Daniel Lezcano
2012-10-31 16:44 ` [PATCH V3 4/4] cpuidle: support multiple drivers Daniel Lezcano
2012-11-02 12:44 ` [PATCH V3 0/4] cpuidle : multiple drivers support Rafael J. Wysocki
2012-11-02 13:19 ` Lorenzo Pieralisi [this message]
2012-11-07 13:32 ` Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121102131950.GA4432@e102568-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).