From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 6/9] cgroup_freezer: make freezer->state mask of flags Date: Wed, 7 Nov 2012 20:42:55 -0800 Message-ID: <20121108044255.GG2660@mtj.dyndns.org> References: <1351931915-1701-1-git-send-email-tj@kernel.org> <1351931915-1701-7-git-send-email-tj@kernel.org> <509B371E.9050005@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <509B371E.9050005-+CUm20s59erQFUHtdCDX3A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Kamezawa Hiroyuki Cc: rjw-KKrjLPT3xs0@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mhocko-AlSwsSmVLrQ@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-pm@vger.kernel.org Hello, Kame. On Thu, Nov 08, 2012 at 01:37:50PM +0900, Kamezawa Hiroyuki wrote: > How about > enum { > __CGROUP_FREEZING, > __CGROUP_FROZEN, > }; > > #define CGROUP_FREEZER_STATE_MASK 0x3 > #define CGROUP_FREEZER_STATE(state) ((state) & CGROUP_FREEZER_STATE_MASK) > #define CGROUP_THAW(state) (CGROUP_FREEZER_STATE(state) == 0) > #define CGROUP_FREEZING(state) (CGROUP_FREEZER_STATE(state) == __CGROUP_FREEZING) > #define CGROUP_FROZEN(state)\ > (CGROUP_FREEZER_STATE(state) == (__CGROUP_FREEZING | __CGROUP_FROZEN)) I think it's a bit overdone and we have cases where we test for FREEZING regardless of FROZEN and cases where test for FREEZING && !FROZEN. We can have, say, CGROUP_FREZING() and then CGROUP_FREEZING_BUT_NOT_FROZEN(), but it feels more like obfuscation than anything else. > >@@ -290,9 +284,9 @@ static int freezer_write(struct cgroup *cgroup, struct cftype *cft, > > { > > bool freeze; > > > >- if (strcmp(buffer, freezer_state_strs[CGROUP_THAWED]) == 0) > >+ if (strcmp(buffer, freezer_state_strs(0)) == 0) > > Can't we have a name for "0" ? We can define CGROUP_THAWED to be zero. I'd rather keep it explicitly zero tho. freezer state is mask of freezing and frozen flags and no flag set means thawed. Thanks. -- tejun