From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v9 05/10] libata: separate ATAPI code Date: Sun, 18 Nov 2012 07:01:17 -0800 Message-ID: <20121118150117.GK7306@mtj.dyndns.org> References: <1352443922-13734-1-git-send-email-aaron.lu@intel.com> <1352443922-13734-6-git-send-email-aaron.lu@intel.com> <20121112185710.GD5560@mtj.dyndns.org> <20121113124923.GA11672@aaronlu.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20121113124923.GA11672@aaronlu.sh.intel.com> Sender: linux-ide-owner@vger.kernel.org To: Aaron Lu Cc: Jeff Garzik , James Bottomley , "Rafael J. Wysocki" , Alan Stern , Jeff Wu , Aaron Lu , linux-ide@vger.kernel.org, linux-pm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-acpi@vger.kernel.org List-Id: linux-pm@vger.kernel.org On Tue, Nov 13, 2012 at 08:49:24PM +0800, Aaron Lu wrote: > On Mon, Nov 12, 2012 at 10:57:10AM -0800, Tejun Heo wrote: > > On Fri, Nov 09, 2012 at 02:51:57PM +0800, Aaron Lu wrote: > > > The atapi_eh_tur and atapi_eh_request_sense can be reused by ZPODD > > > code, so separate them out to a file named libata-atapi.c, and the > > > Makefile is modified accordingly. No functional changes should result > > > from this commit. > > > > Why is this change necessary? This doesn't seem to help anything to > > me. > > Function zpready introduced in patch 6 used these 2 functions to see if > an ODD is in a zero power ready state. And why zpready can't use the functions if they're in a different file? -- tejun