public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: linux-usb@vger.kernel.org
Cc: linux-pm@vger.kernel.org, alsa-devel@alsa-project.org,
	"David Banks" <amoebae@gmail.com>,
	"Olivier MATZ" <zer0@droids-corp.org>,
	"Ralf Lang" <lang@b1-systems.de>,
	"Steffen Müller" <steffen.mueller@radio-frei.de>,
	stable@vger.kernel.org
Subject: [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49
Date: Sun, 25 Nov 2012 13:21:00 -0800	[thread overview]
Message-ID: <20121125212100.GE24024@elie.Belkin> (raw)
In-Reply-To: <50B2815E.2090105@droids-corp.org>

Some USB MIDI keyboards fail to operate after a USB autosuspend.  The
device is recognized by ALSA, but no events are received and the
device goes quiet.

	$ amidi -l
	Dir Device    Name
	IO  hw:1,0,0  Oxygen 49 MIDI 1
	$ amidi -p hw:1,0,0 -d
	<... play some notes ...>
	^C
	0 bytes read

A workaround is to disable USB autosuspend for these devices by
putting AUTOSUSPEND_USBID_BLACKLIST="0763:2027" (resp. 0763:019b) in
/etc/laptop-mode/conf.d/usb-autosuspend.conf.  In the spirit of commit
166cb70e97bd ("usb: add USB_QUIRK_RESET_RESUME for M-Audio 88es"),
reset the device on resume so this workaround is not needed any more.

Noticed on a kernel close to 3.2.10.  Tested against 3.6.5.  Debian's
2.6.32.54-based kernel did not seem to be affected, though it's not
clear whether that is due to code or configuration.

Addresses http://bugs.debian.org/664068

Reported-and-tested-by: David Banks <amoebae@gmail.com> # Oxygen 49
Reported-and-tested-by: Olivier MATZ <zer0@droids-corp.org> # KeyRig 49
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Cc: stable@vger.kernel.org
---
Thoughts?

 drivers/usb/core/quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index fdefd9c7f7af..998c6a8290f6 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -105,6 +105,12 @@ static const struct usb_device_id usb_quirk_list[] = {
 	/* Midiman M-Audio Keystation 88es */
 	{ USB_DEVICE(0x0763, 0x0192), .driver_info = USB_QUIRK_RESET_RESUME },
 
+	/* Midiman M-Audio KeyRig 49 */
+	{ USB_DEVICE(0x0763, 0x019b), .driver_info = USB_QUIRK_RESET_RESUME },
+
+	/* Midiman M-Audio Oxygen 49 */
+	{ USB_DEVICE(0x0763, 0x2027), .driver_info = USB_QUIRK_RESET_RESUME },
+
 	/* M-Systems Flash Disk Pioneers */
 	{ USB_DEVICE(0x08ec, 0x1000), .driver_info = USB_QUIRK_RESET_RESUME },
 
-- 
1.8.0

       reply	other threads:[~2012-11-25 21:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4FA2D481.4070304@droids-corp.org>
     [not found] ` <4FA2DB9D.1040303@droids-corp.org>
     [not found]   ` <20120604110608.GG8248@droids-corp.org>
     [not found]     ` <20120605232432.GE3619@burratino>
     [not found]       ` <4FD06563.7050605@droids-corp.org>
     [not found]         ` <20121125094110.GA21387@elie.Belkin>
     [not found]           ` <50B2815E.2090105@droids-corp.org>
2012-11-25 21:21             ` Jonathan Nieder [this message]
     [not found]               ` <20121125212100.GE24024-fcEM2ccDkbL2nhBuCrrZHw@public.gmane.org>
2012-11-25 22:01                 ` [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49 Clemens Ladisch
     [not found]                   ` <50B29537.7060007-P6GI/4k7KOmELgA04lAiVw@public.gmane.org>
2012-11-26  9:35                     ` Takashi Iwai
2012-11-26 12:35                       ` Clemens Ladisch
2012-11-26 13:04                         ` Takashi Iwai
     [not found]                           ` <s5hwqx8h5w1.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2012-11-26 13:43                             ` Clemens Ladisch
2012-11-26 13:54                               ` Oliver Neukum
2012-11-26 16:12                                 ` Alan Stern
     [not found]                                   ` <Pine.LNX.4.44L0.1211261111130.2168-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-11-26 20:12                                     ` Clemens Ladisch
2012-11-26 21:54                                       ` Alan Stern
2012-11-26 13:58                               ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121125212100.GE24024@elie.Belkin \
    --to=jrnieder@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=amoebae@gmail.com \
    --cc=lang@b1-systems.de \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=steffen.mueller@radio-frei.de \
    --cc=zer0@droids-corp.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox