From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH 4/6 v5] arm highbank: add support for pl320 IPC Date: Tue, 27 Nov 2012 17:12:50 +0100 Message-ID: <20121127171250.3984e990@skate> References: <1351631056-25938-1-git-send-email-mark.langsdorf@calxeda.com> <1354028674-23685-1-git-send-email-mark.langsdorf@calxeda.com> <1354028674-23685-5-git-send-email-mark.langsdorf@calxeda.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mail.free-electrons.com ([88.190.12.23]:60109 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755399Ab2K0QNC (ORCPT ); Tue, 27 Nov 2012 11:13:02 -0500 In-Reply-To: <1354028674-23685-5-git-send-email-mark.langsdorf@calxeda.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Mark Langsdorf Cc: linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Omar Ramirez Luna , Arnd Bergmann , Rob Herring Dear Mark Langsdorf, On Tue, 27 Nov 2012 09:04:32 -0600, Mark Langsdorf wrote: > +int ipc_transmit(u32 *data); ipc_transmit() looks to me like a way to generic name to be exposed to the entire kernel. > +extern int pl320_ipc_register_notifier(struct notifier_block *nb); > +extern int pl320_ipc_unregister_notifier(struct notifier_block *nb); Why some "extern" here? You don't have these for the other functions in this header file. Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com