From: Dave Jones <davej@redhat.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Rafal Bilski <rafalbilski@interia.pl>,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] Longhaul: Disable driver by default
Date: Tue, 27 Nov 2012 17:41:15 -0500 [thread overview]
Message-ID: <20121127224115.GA11301@redhat.com> (raw)
In-Reply-To: <1997813.IluQxocScm@vostro.rjw.lan>
On Tue, Nov 27, 2012 at 11:33:10PM +0100, Rafael J. Wysocki wrote:
> On Tuesday, November 27, 2012 10:13:55 PM Rafal Bilski wrote:
> > This is only solution I can think of. User decides if he wants this
> > driver on his machine. I don't have enough knowledge and time to find
> > the reason why same code works on some machines and doesn't on others
> > which use same, or very similar, chipset and processor.
>
> I always have problems with patches like this one, because they are pretty much
> guaranteed to make someone complain.
>
> Is there any way to blacklist the affected machine you have?
There are a lot of marginal VIA systems out there. Mostly due to really
poor quality motherboards (I had several myself that ended up with leaking
capacitors). They work fine until you put them under load and then start
tweaking the voltage. Rafal spent a long time trying to get them stable
(see the git history for longhaul.c).
Given those CPUs are pretty underpowered today, and there are many better
alternatives if you care about power saving that much, I'd vote for
not worrying about it too much. We even stopped building it in Fedora
due to a) the limited userbase and b) when we got bug reports there was
nothing we could really do, so we opted for stability over power saving.
Dave
next prev parent reply other threads:[~2012-11-27 22:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 22:13 [PATCH] Longhaul: Disable driver by default Rafal Bilski
2012-11-27 22:33 ` Rafael J. Wysocki
2012-11-27 22:41 ` Dave Jones [this message]
2012-11-27 23:38 ` Rafał Bilski
2012-11-27 23:44 ` Rafael J. Wysocki
2012-12-15 0:06 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121127224115.GA11301@redhat.com \
--to=davej@redhat.com \
--cc=cpufreq@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafalbilski@interia.pl \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox