From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v9 06/10] ata: zpodd: check zero power ready status Date: Mon, 3 Dec 2012 08:23:23 -0800 Message-ID: <20121203162323.GB19802@htj.dyndns.org> References: <1352443922-13734-1-git-send-email-aaron.lu@intel.com> <35648985.61QNrr0Knq@vostro.rjw.lan> <1353906191.2523.25.camel@dabdike> <21511277.LLinyDpbAK@vostro.rjw.lan> <20121128013928.GB15971@htj.dyndns.org> <1354092969.2276.49.camel@dabdike> <20121203081321.GA9990@mint-spring.sh.intel.com> <1354523143.2307.2.camel@dabdike.int.hansenpartnership.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1354523143.2307.2.camel@dabdike.int.hansenpartnership.com> Sender: linux-acpi-owner@vger.kernel.org To: James Bottomley Cc: Aaron Lu , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, Jeff Garzik , Alan Stern , Jeff Wu , Aaron Lu , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-acpi@vger.kernel.org List-Id: linux-pm@vger.kernel.org Hello, James. On Mon, Dec 03, 2012 at 08:25:43AM +0000, James Bottomley wrote: > > diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h > > index e65c62e..1756151 100644 > > --- a/include/scsi/scsi_device.h > > +++ b/include/scsi/scsi_device.h > > @@ -160,6 +160,7 @@ struct scsi_device { > > unsigned can_power_off:1; /* Device supports runtime power off */ > > unsigned wce_default_on:1; /* Cache is ON by default */ > > unsigned no_dif:1; /* T10 PI (DIF) should be disabled */ > > + unsigned event_driven:1; /* No need to poll the device */ > > > > DECLARE_BITMAP(supported_events, SDEV_EVT_MAXBITS); /* supported events */ > > struct list_head event_list; /* asserted events */ > > Yes, but if we can get away with doing that, it should be in genhd > because it's completely generic. > > I was imagining we'd have to fake the reply to the test unit ready or > some other commands, which is why it would need to be in sr.c > > The check events code is Tejun's baby, if he's OK with it then just do > it in genhd.c The problem here is there's no easy to reach genhd from libata (or the other way around) without going through sr. I think we're gonna have to have something in sr one way or the other. Thanks. -- tejun