linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: tglx@linutronix.de, peterz@infradead.org,
	paulmck@linux.vnet.ibm.com, rusty@rustcorp.com.au,
	mingo@kernel.org, akpm@linux-foundation.org, namhyung@kernel.org,
	vincent.guittot@linaro.org, tj@kernel.org, oleg@redhat.com
Cc: sbw@mit.edu, amit.kucheria@linaro.org, rostedt@goodmis.org,
	rjw@sisk.pl, srivatsa.bhat@linux.vnet.ibm.com,
	wangyun@linux.vnet.ibm.com, xiaoguangrong@linux.vnet.ibm.com,
	nikunj@linux.vnet.ibm.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [RFC PATCH v4 8/9] kvm, vmx: Add atomic synchronization with CPU Hotplug
Date: Tue, 11 Dec 2012 19:35:32 +0530	[thread overview]
Message-ID: <20121211140528.23621.52490.stgit@srivatsabhat.in.ibm.com> (raw)
In-Reply-To: <20121211140314.23621.64088.stgit@srivatsabhat.in.ibm.com>

preempt_disable() will no longer help prevent CPUs from going offline, once
stop_machine() gets removed from the CPU offline path. So use
get/put_online_cpus_atomic() in vmx_vcpu_load() to prevent CPUs from
going offline while clearing vmcs.

Reported-by: Michael Wang <wangyun@linux.vnet.ibm.com>
Debugged-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
---

 arch/x86/kvm/vmx.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index f858159..d8a4cf1 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -1519,10 +1519,14 @@ static void vmx_vcpu_load(struct kvm_vcpu *vcpu, int cpu)
 	struct vcpu_vmx *vmx = to_vmx(vcpu);
 	u64 phys_addr = __pa(per_cpu(vmxarea, cpu));
 
-	if (!vmm_exclusive)
+	if (!vmm_exclusive) {
 		kvm_cpu_vmxon(phys_addr);
-	else if (vmx->loaded_vmcs->cpu != cpu)
+	} else if (vmx->loaded_vmcs->cpu != cpu) {
+		/* Prevent any CPU from going offline */
+		get_online_cpus_atomic();
 		loaded_vmcs_clear(vmx->loaded_vmcs);
+		put_online_cpus_atomic();
+	}
 
 	if (per_cpu(current_vmcs, cpu) != vmx->loaded_vmcs->vmcs) {
 		per_cpu(current_vmcs, cpu) = vmx->loaded_vmcs->vmcs;

  parent reply	other threads:[~2012-12-11 14:05 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-11 14:03 [RFC PATCH v4 0/9] CPU hotplug: stop_machine()-free CPU hotplug Srivatsa S. Bhat
2012-12-11 14:04 ` [RFC PATCH v4 1/9] CPU hotplug: Provide APIs to prevent CPU offline from atomic context Srivatsa S. Bhat
2012-12-12 17:17   ` Oleg Nesterov
2012-12-12 17:24     ` Oleg Nesterov
2012-12-12 18:11       ` Srivatsa S. Bhat
2012-12-12 18:23         ` Oleg Nesterov
2012-12-12 18:42           ` Srivatsa S. Bhat
2012-12-12 17:53     ` Srivatsa S. Bhat
2012-12-12 18:02       ` Oleg Nesterov
2012-12-12 18:30         ` Srivatsa S. Bhat
2012-12-12 18:48           ` Oleg Nesterov
2012-12-12 19:12             ` Srivatsa S. Bhat
2012-12-13 15:26               ` Srivatsa S. Bhat
2012-12-13 16:17                 ` Oleg Nesterov
2012-12-13 16:32                   ` Srivatsa S. Bhat
2012-12-14 18:03                     ` Oleg Nesterov
2012-12-18 15:53                       ` Srivatsa S. Bhat
2012-12-18 19:43                         ` Oleg Nesterov
2012-12-18 20:06                           ` Srivatsa S. Bhat
2012-12-19 16:39                             ` Oleg Nesterov
2012-12-19 18:16                               ` Srivatsa S. Bhat
2012-12-19 19:14                                 ` Oleg Nesterov
2012-12-19 19:49                                   ` Srivatsa S. Bhat
2012-12-20 13:42                                     ` Oleg Nesterov
2012-12-20 14:06                                       ` Srivatsa S. Bhat
2012-12-22 20:17                                       ` Srivatsa S. Bhat
2012-12-23 16:42                                         ` Oleg Nesterov
2012-12-24 15:50                                           ` Srivatsa S. Bhat
2012-12-13 16:32                   ` Tejun Heo
2012-12-12 19:36         ` Oleg Nesterov
2012-12-12 19:43           ` Srivatsa S. Bhat
2012-12-12 21:10             ` Oleg Nesterov
2012-12-11 14:04 ` [RFC PATCH v4 2/9] CPU hotplug: Convert preprocessor macros to static inline functions Srivatsa S. Bhat
2012-12-11 14:04 ` [RFC PATCH v4 3/9] smp, cpu hotplug: Fix smp_call_function_*() to prevent CPU offline properly Srivatsa S. Bhat
2012-12-11 14:04 ` [RFC PATCH v4 4/9] smp, cpu hotplug: Fix on_each_cpu_*() " Srivatsa S. Bhat
2012-12-11 14:05 ` [RFC PATCH v4 5/9] sched, cpu hotplug: Use stable online cpus in try_to_wake_up() & select_task_rq() Srivatsa S. Bhat
2012-12-11 14:05 ` [RFC PATCH v4 6/9] kick_process(), cpu-hotplug: Prevent offlining of target CPU properly Srivatsa S. Bhat
2012-12-11 14:05 ` [RFC PATCH v4 7/9] yield_to(), cpu-hotplug: Prevent offlining of other CPUs properly Srivatsa S. Bhat
2012-12-11 14:05 ` Srivatsa S. Bhat [this message]
2012-12-11 14:05 ` [RFC PATCH v4 9/9] cpu: No more __stop_machine() in _cpu_down() Srivatsa S. Bhat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121211140528.23621.52490.stgit@srivatsabhat.in.ibm.com \
    --to=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=amit.kucheria@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=nikunj@linux.vnet.ibm.com \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rjw@sisk.pl \
    --cc=rostedt@goodmis.org \
    --cc=rusty@rustcorp.com.au \
    --cc=sbw@mit.edu \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=wangyun@linux.vnet.ibm.com \
    --cc=xiaoguangrong@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).