From: Olof Johansson <olof@lixom.net>
To: myungjoo.ham@gmail.com
Cc: Abhilash Kesavan <a.kesavan@samsung.com>,
kyungmin.park@samsung.com, rjw@sisk.pl,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
kgene.kim@samsung.com, jhbird.choi@samsung.com
Subject: Re: [PATCH RFC] PM/Devfreq: Add Exynos5-bus devfreq driver for Exynos5250.
Date: Sat, 29 Dec 2012 22:18:43 -0800 [thread overview]
Message-ID: <20121230061843.GB21331@quad.lixom.net> (raw)
In-Reply-To: <CAJ0PZbTTDdAXJ378R7CDO2=spx7WF_RpztG5ch7iFZWx-v3N2Q@mail.gmail.com>
Hi,
On Tue, Dec 11, 2012 at 10:20:51AM +0900, MyungJoo Ham wrote:
> On Fri, Nov 30, 2012 at 5:42 PM, Abhilash Kesavan <a.kesavan@samsung.com> wrote:
> > drivers/devfreq/Kconfig | 10 +
> > drivers/devfreq/Makefile | 1 +
> > drivers/devfreq/exynos5_bus.c | 595 ++++++++++++++++++++++++++++++++++++++++
> > drivers/devfreq/exynos5_ppmu.c | 395 ++++++++++++++++++++++++++
> > drivers/devfreq/exynos5_ppmu.h | 26 ++
> > drivers/devfreq/exynos_ppmu.c | 56 ++++
> > drivers/devfreq/exynos_ppmu.h | 79 ++++++
> > 7 files changed, 1162 insertions(+), 0 deletions(-)
> > create mode 100644 drivers/devfreq/exynos5_bus.c
> > create mode 100644 drivers/devfreq/exynos5_ppmu.c
> > create mode 100644 drivers/devfreq/exynos5_ppmu.h
> > create mode 100644 drivers/devfreq/exynos_ppmu.c
> > create mode 100644 drivers/devfreq/exynos_ppmu.h
>
> I understand that Exynos PPMU drivers seem not to be used (at least in
> mainline Linux) widely and it'd be convinent for a bus driver to have
> ppmu driver located in the same source directory.
>
> However, I don't feel very comfortable to have ppmu drivers explicitly
> landing in devfreq directory. Would it be possible to place them
> somewhere else? (in drivers/misc, arch/arm/mach-exynos, or somewhere
> appropriate?) If PPMU drivers really have nowhere to relocate, they
> may be located along with its sole user (exynos5_bus.c) anyway.
Why can't they be in drivers/busfreq? Create a subdirectory for
platform-specific subdrivers if needed, but they definitiely do NOT
belong in drivers/misc, and there seems to be little reason to have them
in arch/arm.
-Olof
next prev parent reply other threads:[~2012-12-30 6:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 8:42 [PATCH RFC] PM/Devfreq: Add Exynos5-bus devfreq driver for Exynos5250 Abhilash Kesavan
2012-12-04 9:36 ` Jonghwan Choi
2012-12-04 16:18 ` Abhilash Kesavan
2012-12-05 3:05 ` Abhilash Kesavan
2012-12-11 1:20 ` MyungJoo Ham
2012-12-28 9:22 ` [PATCH] " Abhilash Kesavan
2012-12-30 6:18 ` Olof Johansson [this message]
2012-12-31 2:11 ` [PATCH RFC] " Abhilash Kesavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121230061843.GB21331@quad.lixom.net \
--to=olof@lixom.net \
--cc=a.kesavan@samsung.com \
--cc=jhbird.choi@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@gmail.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox