From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v12 8/9] libata: do not suspend port if normal ODD is attached Date: Thu, 10 Jan 2013 11:57:55 -0800 Message-ID: <20130110195755.GM20454@htj.dyndns.org> References: <1357809870-18816-1-git-send-email-aaron.lu@intel.com> <1357809870-18816-9-git-send-email-aaron.lu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pb0-f48.google.com ([209.85.160.48]:56002 "EHLO mail-pb0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755941Ab3AJT6C (ORCPT ); Thu, 10 Jan 2013 14:58:02 -0500 Content-Disposition: inline In-Reply-To: <1357809870-18816-9-git-send-email-aaron.lu@intel.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Aaron Lu Cc: Jeff Garzik , James Bottomley , "Rafael J. Wysocki" , Alan Stern , Aaron Lu , Jeff Wu , linux-ide@vger.kernel.org, linux-pm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-acpi@vger.kernel.org On Thu, Jan 10, 2013 at 05:24:29PM +0800, Aaron Lu wrote: > For ODDs, the upper layer will poll for media change every few > seconds, which will make it enter and leave suspend state very > often. And as each suspend will also cause a hard/soft reset, > the gain of runtime suspend is very little while the ODD may > malfunction after constantly being reset. So the idle callback > here will not proceed to suspend if a non-ZPODD capable ODD is > attached to the port. > > Signed-off-by: Aaron Lu Acked-by: Tejun Heo Thanks. -- tejun