From: jacob pan <jacob.jun.pan@linux.intel.com>
To: Zhang Rui <rui.zhang@intel.com>
Cc: Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Len Brown <len.brown@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
Joe Perches <joe@perches.com>, Rob Landley <rob@landley.net>,
Arjan van de Ven <arjan@linux.intel.com>,
Paul McKenney <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH v6 3/3] PM: Introduce Intel PowerClamp Driver
Date: Wed, 16 Jan 2013 09:09:50 -0800 [thread overview]
Message-ID: <20130116090950.00007e90@unknown> (raw)
In-Reply-To: <1358338729.2252.53.camel@rzhang1-mobl4>
On Wed, 16 Jan 2013 20:18:49 +0800
Zhang Rui <rui.zhang@intel.com> wrote:
> > +#include <linux/nmi.h>
> > +
> drivers/thermal/intel_powerclamp.c: In function ‘clamp_thread’:
> drivers/thermal/intel_powerclamp.c:435:4: error: implicit declaration
> of function ‘local_touch_nmi’ [-Werror=implicit-function-declaration]
>
> changing to
> #include <asm/nmi.h>
> fixes the problem.
good catch. I missed this in my .config tests. I had
CONFIG_HARDLOCKUP_DETECTOR on so the problem was not shown. I will send
you an update.
Thanks,
Jacob
next prev parent reply other threads:[~2013-01-16 17:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 11:12 [PATCH v6 0/3] PM: Intel PowerClamp driver Jacob Pan
2013-01-04 11:12 ` [PATCH v6 1/3] tick: export nohz tick idle symbols for module use Jacob Pan
2013-01-17 14:34 ` Zhang Rui
2013-01-04 11:12 ` [PATCH v6 2/3] x86/nmi: export local_touch_nmi() symbol for modules Jacob Pan
2013-01-17 14:35 ` Zhang Rui
2013-01-04 11:12 ` [PATCH v6 3/3] PM: Introduce Intel PowerClamp Driver Jacob Pan
2013-01-16 12:18 ` Zhang Rui
2013-01-16 12:20 ` Zhang Rui
2013-01-16 17:09 ` jacob pan [this message]
2013-01-11 22:37 ` [PATCH v6 0/3] PM: Intel PowerClamp driver Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130116090950.00007e90@unknown \
--to=jacob.jun.pan@linux.intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=arjan@linux.intel.com \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rob@landley.net \
--cc=rui.zhang@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).