From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH] drivers/cpufreq: Warn user when powernow-k8 tries to fall back to acpi-cpufreq and it is unavailable. Date: Fri, 18 Jan 2013 18:07:55 +0100 Message-ID: <20130118170755.GB4062@pd.tnic> References: <1357780161-30581-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <20130111144940.GB21882@liondog.tnic> <20130111165054.GD10751@liondog.tnic> <4923C2DE085EEB4FAB1D375DD09D0BA6100CF170@sausexdag04.amd.com> <20130117115436.GA3853@pd.tnic> <20130118162347.GA31499@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20130118162347.GA31499@srcf.ucam.org> Sender: linux-kernel-owner@vger.kernel.org To: Matthew Garrett Cc: "Gopalakrishnan, Aravind" , "rjw@sisk.pl" , Andre Przywara , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Andreas List-Id: linux-pm@vger.kernel.org On Fri, Jan 18, 2013 at 04:23:47PM +0000, Matthew Garrett wrote: > On Thu, Jan 17, 2013 at 12:54:37PM +0100, Borislav Petkov wrote: > > > So, handoff to acpi-cpufreq still has some issues. When both are > > built-in, the module_init functions turn into normal initcalls and > > in that case, they're executed in link order and it can happen that > > powernowk8_init() runs before acpi_cpufreq_init(). > > Just flip the link order? It's only the way it is because in the past we > wanted to try hardware-specific drivers before more generic ones, and I > don't think that's a concern in this case now. Yeah, I heard that the acpi-idle and intel-idle drivers do that and also heard that it was a hack. It doesn't look too ugly IMHO: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=2671717265ae6e720a9ba5f13fbec3a718983b65 -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --