From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
Goswin von Brederlow <goswin-v-b@web.de>,
Li Fei <fei.li@intel.com>,
len.brown@intel.com, mingo@redhat.com, peterz@infradead.org,
biao.wang@intel.com, linux-pm@vger.kernel.org,
fuse-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
chuansheng.liu@intel.com
Subject: Re: Getting rid of freezer for suspend [was Re: [fuse-devel] [PATCH] fuse: make fuse daemon frozen along with kernel threads]
Date: Mon, 11 Feb 2013 11:53:14 +0100 [thread overview]
Message-ID: <20130211105314.GA32322@amd.pavel.ucw.cz> (raw)
In-Reply-To: <2964781.rPUOipNRNb@vostro.rjw.lan>
Hi!
> > > > > > The whole memory shrinking we do for hibernation is now done by allocating
> > > > > > memory, so the freezer is not necessary for *that* and there's *zero*
> > > > > > difference between suspend and hibernation with respect to why the freezer is
> > > > > > used.
> > > > >
> > > > > Funny. Freezer was put there so that hibernation image was safe to
> > > > > write out. You need disk subsystems in workable state for hibernation.
> > > >
> > > > I'm not really sure what you're talking about. Why do you think the freezer is
> > > > necessary for that?
> >
> > Well, from freezer you need:
> >
> > 1) user process frozen.
> >
> > 2) essential locks _not_ held so that block devices are still functional.
> >
> > > > > mmap... what is problem with mmap? For suspend, memory is powered, so
> > > > > you can permit people changing it.
> > > >
> > > > Suppose mmap is used to make the registers of some device available to user
> > > > space. Yes, that can happen.
> >
> > "Don't do it, then". Yes, can happen, but hopefully is not too common
> > these days. [And... freezer doing 1) but not 2) would be enough to
> > handle that. Freezer doing 1) but not 2) would also be simpler...]
>
> Again, I'm not sure what you mean.
>
> Are you trying to say that it would be OK to freeze user space tasks in
> the D state?
Yes. For suspend, that should pretty much work. (With caveats, as
Miklos noticed).
Unfortunately, that is not going to be too easy for hibernation.
We could mae the situation easier by specifying we only support
hibernation to local SATA or SCSI disk, not over NBD, iSCSI,
etc... That would reduce number of locks that need to be available for
hibernation.
Unfortunately, uswsusp did not make that easy as userland may want to
do arbitrary stuff with the image.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2013-02-11 10:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 1:11 [PATCH] fuse: make fuse daemon frozen along with kernel threads Li Fei
2013-02-06 9:27 ` Miklos Szeredi
[not found] ` <20130207084144.GB6168@frosties>
2013-02-07 9:59 ` [fuse-devel] " Miklos Szeredi
2013-02-08 14:11 ` Goswin von Brederlow
2013-02-09 17:49 ` Pavel Machek
2013-02-09 20:31 ` Rafael J. Wysocki
2013-02-10 10:33 ` Getting rid of freezer for suspend [was Re: [fuse-devel] [PATCH] fuse: make fuse daemon frozen along with kernel threads] Pavel Machek
2013-02-10 13:51 ` Rafael J. Wysocki
2013-02-10 14:22 ` Rafael J. Wysocki
2013-02-10 18:55 ` Pavel Machek
2013-02-10 23:31 ` Rafael J. Wysocki
2013-02-11 10:11 ` Miklos Szeredi
2013-02-11 12:08 ` Rafael J. Wysocki
2013-02-11 13:59 ` Miklos Szeredi
2013-02-11 19:28 ` Rafael J. Wysocki
2013-02-12 10:46 ` Pavel Machek
2013-02-12 13:13 ` Miklos Szeredi
2013-02-12 13:17 ` Miklos Szeredi
2013-02-13 17:34 ` Miklos Szeredi
2013-02-13 20:16 ` Pavel Machek
2013-02-14 10:31 ` Miklos Szeredi
2013-02-13 21:21 ` Rafael J. Wysocki
2013-02-14 10:41 ` Miklos Szeredi
2013-02-14 12:11 ` Rafael J. Wysocki
2013-02-14 13:09 ` Miklos Szeredi
2013-02-14 17:38 ` Rafael J. Wysocki
2013-02-18 6:26 ` Li, Fei
2013-02-18 12:26 ` Rafael J. Wysocki
2013-02-19 10:46 ` Pavel Machek
2013-02-20 2:54 ` Li, Fei
[not found] ` <BEC9F67575FA1E429CA7CF5AE9BE3634403505-0J0gbvR4kTiiAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-02-20 13:13 ` Getting rid of freezer for suspend [was " Miklos Szeredi
2013-02-11 10:53 ` Pavel Machek [this message]
2013-02-06 9:56 ` [fuse-devel] [PATCH] fuse: make fuse daemon frozen along with kernel threads Han-Wen Nienhuys
2013-02-06 14:59 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211105314.GA32322@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=biao.wang@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=fei.li@intel.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=goswin-v-b@web.de \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox