From: Nishanth Menon <nm@ti.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-pm <linux-pm@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PM / OPP: improve introductory documentation
Date: Tue, 26 Feb 2013 17:44:17 -0600 [thread overview]
Message-ID: <20130226234417.GA24893@kahuna> (raw)
In-Reply-To: <512D47AB.9030401@infradead.org>
On 15:39-20130226, Randy Dunlap wrote:
> On 02/26/13 15:10, Nishanth Menon wrote:
> > On 14:43-20130226, Randy Dunlap wrote:
> >> On 02/26/13 09:37, Nishanth Menon wrote:
> > [..]
> >>>
> >>> 1. Introduction
> >>> ===============
> >>> +1.1 What is an Operating Performance Point (OPP)?
> >>> +
> >>> Complex SoCs of today consists of a multiple sub-modules working in conjunction.
> >>> In an operational system executing varied use cases, not all modules in the SoC
> >>> need to function at their highest performing frequency all the time. To
> >>> facilitate this, sub-modules in a SoC are grouped into domains, allowing some
> >>> domains to run at lower voltage and frequency while other domains are loaded
> >>> -more. The set of discrete tuples consisting of frequency and voltage pairs that
> >>> +more.
> >>
> >> huh???
> > I split the definition line to it's own paragraph below. But, I think
> > you intend to say we could improve better the remaining paragraph.
> > Could you elaborate your thoughts?
>
> "while other domains are loaded more." Some people probably understand
> that OK; I dunno. I would rather see it written out more verbosely, e.g.:
>
> "while other domains run at voltage/frequency pairs that are higher."
You are right, being verbose here makes sense. I will pick up your wording
here in v2. Thanks for reviewing and helping improve.
>
> but partly I was confused by the diff(1) lines. my bad :(
no worries.
--
Regards,
Nishanth Menon
prev parent reply other threads:[~2013-02-26 23:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 17:37 [PATCH] PM / OPP: improve introductory documentation Nishanth Menon
2013-02-26 22:43 ` Randy Dunlap
2013-02-26 23:10 ` Nishanth Menon
2013-02-26 23:39 ` Randy Dunlap
2013-02-26 23:44 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130226234417.GA24893@kahuna \
--to=nm@ti.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox