From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue Date: Thu, 7 Mar 2013 00:51:19 +0000 Message-ID: <20130307005119.GY17833@n2100.arm.linux.org.uk> References: <20130305105251.GL17833@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:55732 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753805Ab3CGAvi (ORCPT ); Wed, 6 Mar 2013 19:51:38 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Viresh Kumar Cc: rjw@sisk.pl, Steve.Bannister@arm.com, linux-pm@vger.kernel.org, Sudeep KarkadaNagesha , Liviu.Dudau@arm.com, linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org, robin.randhawa@arm.com, linux-arm-kernel@lists.infradead.org, mark.hambleton@broadcom.com, linaro-kernel@lists.linaro.org, charles.garcia-tobin@arm.com On Thu, Mar 07, 2013 at 08:32:37AM +0800, Viresh Kumar wrote: > On 5 March 2013 18:52, Russell King - ARM Linux wrote: > > On Tue, Mar 05, 2013 at 12:52:41PM +0800, Viresh Kumar wrote: > >> + clk[cluster] = clk_get(NULL, name); > >> + if (!IS_ERR_OR_NULL(clk[cluster])) { > > > > NAK. Two reasons. > > > > 1. IS_ERR_OR_NULL. You know about this, it's been on the list several > > times. > > Hey, i had a second thought about this one and i have some other opinion > here. This is a cpufreq driver and we need clock support for sure here, we > can't work without it. And so here is the latest fixup: NAK. You just don't understand.