From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacob Shin Subject: Re: [PATCH V2 0/2] cpufreq: ondemand: add AMD specific powersave bias Date: Mon, 1 Apr 2013 14:38:39 -0500 Message-ID: <20130401193839.GA15738@jshin-Toonie> References: <1364495057-14939-1-git-send-email-jacob.shin@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from va3ehsobe010.messaging.microsoft.com ([216.32.180.30]:1455 "EHLO va3outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758854Ab3DATit (ORCPT ); Mon, 1 Apr 2013 15:38:49 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: "Rafael J. Wysocki" , Viresh Kumar Cc: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, Mar 29, 2013 at 08:18:54AM +0530, Viresh Kumar wrote: > On 28 March 2013 23:54, Jacob Shin wrote: > > This patchset adds AMD specific powersave bias function to the ondemand > > governor; which can be used to help ondemand governor make more power conscious > > frequency change decisions based on feedback from hardware (availble on AMD > > Family 16h and above). > > > > Hardware feedback tells software how "sensitive" to frequency changes the > > workloads are. CPU-bound workloads will be more sensitive -- they will > > perform better as frequency increases. Memory/IO-bound workloads will be less > > sensitive -- they will not necessarily perform better as frequnecy increases. > > > > This patchset was compared against ondemand governor without powersave bias > > and did not show any performance degradation on CPU-bound workloads such as > > kernbench and unixbench. While saving power on Memory-bound workloads such as > > stream. > > > > This applies to linux-pm's linux-next branch, on top of Viresh's 'Implement > > per policy instance of governor' V4 patchset: > > > > https://lkml.org/lkml/2013/3/27/348 > > > > V2: > > * Added proper include files to amd_freq_sensitivity.c > > * Only register powersave_bias_target function pointer and not the entire > > od_ops. > > > > Jacob Shin (2): > > cpufreq: ondemand: allow custom powersave_bias_target function to be > > registered > > cpufreq: AMD "frequency sensitivity feedback" powersave bias for > > ondemand governor > > > > arch/x86/include/uapi/asm/msr-index.h | 1 + > > drivers/cpufreq/Kconfig.x86 | 10 +++ > > drivers/cpufreq/Makefile | 1 + > > drivers/cpufreq/amd_freq_sensitivity.c | 147 ++++++++++++++++++++++++++++++++ > > drivers/cpufreq/cpufreq_governor.h | 3 + > > drivers/cpufreq/cpufreq_ondemand.c | 22 ++++- > > 6 files changed, 181 insertions(+), 3 deletions(-) > > create mode 100644 drivers/cpufreq/amd_freq_sensitivity.c > > Acked-by: Viresh Kumar > Hi Rafael, If this looks okay to you, please commit to linux-next when you get the chance. Thanks!