From: Simon Horman <horms@verge.net.au>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: rjw@sisk.pl, linus.walleij@linaro.org, jason@lakedaemon.net,
andrew@lunn.ch, kernel@pengutronix.de, swarren@wwwdotorg.org,
santosh.shilimkar@ti.com, nicolas.ferre@atmel.com,
plagnioj@jcrosoft.com, linux@maxim.org.za,
rob.herring@calxeda.com, nsekhar@ti.com, magnus.damm@gmail.com,
deepthi@linux.vnet.ibm.com, lethal@linux-sh.org, jkosina@suse.cz,
kgene.kim@samsung.com, khilman@deeprootsystems.com,
tony@atomide.com, linux-pm@vger.kernel.org, patches@linaro.org,
linux-arm-kernel@lists.infradead.org,
linaro-kernel@lists.linaro.org, josephl@nvidia.com
Subject: Re: [V2 patch 01/19] ARM: shmobile: cpuidle: remove shmobile_enter_wfi function
Date: Fri, 12 Apr 2013 09:44:25 +0900 [thread overview]
Message-ID: <20130412004425.GD24461@verge.net.au> (raw)
In-Reply-To: <1365712969-7541-2-git-send-email-daniel.lezcano@linaro.org>
On Thu, Apr 11, 2013 at 10:42:31PM +0200, Daniel Lezcano wrote:
> Remove the shmobile_enter_wfi function which is the same as the
> common WFI enter function from the arm cpuidle driver defined
> with the ARM_CPUIDLE_WFI_STATE macro.
Should this patch also make shmobile_enter_wfi static in
arch/arm/mach-shmobile/cpuidle.c ?
Also, I have a slight preference for the patch to be split into two.
1. A patch to remove usage of shmobile_enter_wfi from the sh7372 SoC.
2. A patch to remove shmobile_enter_wfi. from common.h
(and make it static?).
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> arch/arm/mach-shmobile/include/mach/common.h | 3 ---
> arch/arm/mach-shmobile/pm-sh7372.c | 1 -
> 2 files changed, 4 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/include/mach/common.h b/arch/arm/mach-shmobile/include/mach/common.h
> index e48606d..362f9b2 100644
> --- a/arch/arm/mach-shmobile/include/mach/common.h
> +++ b/arch/arm/mach-shmobile/include/mach/common.h
> @@ -13,9 +13,6 @@ extern int shmobile_clk_init(void);
> extern void shmobile_handle_irq_intc(struct pt_regs *);
> extern struct platform_suspend_ops shmobile_suspend_ops;
> struct cpuidle_driver;
> -struct cpuidle_device;
> -extern int shmobile_enter_wfi(struct cpuidle_device *dev,
> - struct cpuidle_driver *drv, int index);
> extern void shmobile_cpuidle_set_driver(struct cpuidle_driver *drv);
>
> extern void sh7372_init_irq(void);
> diff --git a/arch/arm/mach-shmobile/pm-sh7372.c b/arch/arm/mach-shmobile/pm-sh7372.c
> index f6b14ca..fbef7b9 100644
> --- a/arch/arm/mach-shmobile/pm-sh7372.c
> +++ b/arch/arm/mach-shmobile/pm-sh7372.c
> @@ -414,7 +414,6 @@ static struct cpuidle_driver sh7372_cpuidle_driver = {
> .state_count = 5,
> .safe_state_index = 0, /* C1 */
> .states[0] = ARM_CPUIDLE_WFI_STATE,
> - .states[0].enter = shmobile_enter_wfi,
> .states[1] = {
> .name = "C2",
> .desc = "Core Standby Mode",
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2013-04-12 0:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 20:42 [V2 patch 00/19] cpuidle: code consolidation Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 01/19] ARM: shmobile: cpuidle: remove shmobile_enter_wfi function Daniel Lezcano
2013-04-12 0:44 ` Simon Horman [this message]
2013-04-12 6:47 ` Daniel Lezcano
2013-04-12 7:06 ` Simon Horman
2013-04-12 7:11 ` Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 02/19] ARM: OMAP3: remove cpuidle_wrap_enter Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 03/19] cpuidle: remove en_core_tk_irqen flag Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 04/19] ARM: ux500: cpuidle: replace for_each_online_cpu by for_each_possible_cpu Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 05/19] ARM: imx: cpuidle: create separate drivers for imx5/imx6 Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 06/19] cpuidle: make a single register function for all Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 07/19] ARM: ux500: cpuidle: use init/exit common routine Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 08/19] ARM: at91: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 09/19] ARM: OMAP3: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 10/19] ARM: s3c64xx: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 11/19] ARM: tegra: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 12/19] ARM: shmobile: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 13/19] ARM: OMAP4: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 14/19] ARM: tegra: cpuidle: use init/exit common routine for tegra2 Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 15/19] ARM: tegra: cpuidle: use init/exit common routine for tegra3 Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 16/19] ARM: calxeda: cpuidle: use init/exit common routine Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 17/19] ARM: kirkwood: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 18/19] ARM: davinci: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 19/19] ARM: imx: " Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130412004425.GD24461@verge.net.au \
--to=horms@verge.net.au \
--cc=andrew@lunn.ch \
--cc=daniel.lezcano@linaro.org \
--cc=deepthi@linux.vnet.ibm.com \
--cc=jason@lakedaemon.net \
--cc=jkosina@suse.cz \
--cc=josephl@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=kgene.kim@samsung.com \
--cc=khilman@deeprootsystems.com \
--cc=lethal@linux-sh.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=magnus.damm@gmail.com \
--cc=nicolas.ferre@atmel.com \
--cc=nsekhar@ti.com \
--cc=patches@linaro.org \
--cc=plagnioj@jcrosoft.com \
--cc=rjw@sisk.pl \
--cc=rob.herring@calxeda.com \
--cc=santosh.shilimkar@ti.com \
--cc=swarren@wwwdotorg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).