From: Mark Brown <broonie@kernel.org>
To: Taras Kondratiuk <taras@ti.com>
Cc: lgirdwood@gmail.com, rjw@sisk.pl, viresh.kumar@linaro.org,
shawn.guo@linaro.org, cpufreq@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Philip Rakity <prakity@nvidia.com>,
Eric Miao <eric.y.miao@gmail.com>
Subject: Re: [RFC PATCH 1/2] regulator: core: Add regulator_set_voltage_min()
Date: Tue, 23 Apr 2013 09:48:39 +0100 [thread overview]
Message-ID: <20130423084838.GB5019@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <51756A21.3020405@ti.com>
[-- Attachment #1: Type: text/plain, Size: 523 bytes --]
On Mon, Apr 22, 2013 at 07:49:37PM +0300, Taras Kondratiuk wrote:
> Yeah. Sure 4kV is not a real request, but
> max will be limited by system constrains.
> According to regulator_set_voltage() documentation
> system constraints should be set before calling this function,
> so I assume I can rely on them. No?
> Another possible implementation is below, but prefer initial one.
I just don't see any reason for this API. The driver setting the
voltage ought to have some idea of what the chip limits are too for
safety.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-04-23 8:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 11:55 [RFC PATCH 0/2] cpufreq/regulator: Limit minimum voltage only Taras Kondratiuk
2013-04-19 11:55 ` [RFC PATCH 1/2] regulator: core: Add regulator_set_voltage_min() Taras Kondratiuk
2013-04-22 13:19 ` Mark Brown
2013-04-22 16:49 ` Taras Kondratiuk
2013-04-23 8:48 ` Mark Brown [this message]
2013-04-23 11:44 ` Taras Kondratiuk
2013-04-23 13:45 ` Mark Brown
2013-04-23 18:45 ` Taras Kondratiuk
2013-04-24 9:38 ` Mark Brown
2013-04-19 11:55 ` [RFC PATCH 2/2] cpufreq: cpufreq-cpu0: Limit minimum voltage only Taras Kondratiuk
2013-04-19 16:21 ` [RFC PATCH 0/2] cpufreq/regulator: " Nishanth Menon
2013-04-20 0:24 ` Kondratiuk, Taras
2013-04-22 6:11 ` Bedia, Vaibhav
2013-04-22 13:25 ` Mark Brown
2013-04-22 16:25 ` Taras Kondratiuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130423084838.GB5019@opensource.wolfsonmicro.com \
--to=broonie@kernel.org \
--cc=cpufreq@vger.kernel.org \
--cc=eric.y.miao@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=prakity@nvidia.com \
--cc=rjw@sisk.pl \
--cc=shawn.guo@linaro.org \
--cc=taras@ti.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).