From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Subject: Re: [PATCH v2 2/4] Thermal: exynos: Support for TMU regulator defined at device tree Date: Thu, 25 Apr 2013 18:29:41 +0200 Message-ID: <20130425182941.63ecff30@amdc308.digital.local> References: <1366389493-8239-1-git-send-email-l.majewski@samsung.com> <1366893045-31586-1-git-send-email-l.majewski@samsung.com> <1366893045-31586-3-git-send-email-l.majewski@samsung.com> <20130425152934.5041cc98@amdc308.digital.local> <51794F48.5040401@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <51794F48.5040401@ti.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Eduardo Valentin Cc: amit daniel kachhap , Kukjin Kim , "devicetree-discuss@lists.ozlabs.org" , Zhang Rui , "linux-samsung-soc@vger.kernel.org" , Linux PM list , t.figa@samsung.com, Sachin Kamat , Myungjoo Ham , Kyungmin Park List-Id: linux-pm@vger.kernel.org Hi Eduardo, > Amit, Lukasz, > > On 25-04-2013 09:29, Lukasz Majewski wrote: > > Hi Amit, > > > >> Hi Lukasz Majewski, > >> > >> Sorry for late review but I am currently working on restructuring > >> the whole exynos thermal driver and this support of LDO can be > >> added as feature as not all socs support this. This is also > >> suggested by Eduardo. All your other patches looks fine. > > > > But this is how it is already done. The VDD_TS is optional, so > > Exynos5440 and Exynos4210 will not be broken. > > > > This shall preserve the correct behavior of the thermal driver. > > > > If you guys plan to move to feature based approach, like suggested in > V1, then Id recommend adding a /* TODO: */ entry in your driver. Ok, nice idea. > > Amit, are you including this LDO support on your rework? -- Best regards, Lukasz Majewski Samsung R&D Poland (SRPOL) | Linux Platform Group