From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 02/10] freezer: skip waking up tasks with PF_FREEZER_SKIP set Date: Mon, 29 Apr 2013 15:16:24 -0700 Message-ID: <20130429221624.GD2395@htj.dyndns.org> References: <1367271946-7239-1-git-send-email-ccross@android.com> <1367271946-7239-3-git-send-email-ccross@android.com> <20130429215157.GA2395@htj.dyndns.org> <20130429215745.GB2395@htj.dyndns.org> <20130429220831.GC2395@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20130429220831.GC2395-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Colin Cross Cc: Len Brown , Linux PM list , containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, lkml , "Rafael J. Wysocki" , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Pavel Machek , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-pm@vger.kernel.org On Mon, Apr 29, 2013 at 03:08:31PM -0700, Tejun Heo wrote: > > spent freezing by a factor of 5. It will have a similar effect on a > > non-Android system, although those generally don't care about > > suspend/resume optimization. > > Yeah, if it's something which makes actual difference rather than > "this seems to be a good idea" thing, sure, let's find a way. And a probably better approach would be rolling should_skip test into freeze_task() with a comment explaining the interlocking rather than adding should_skip test in its callers. Thanks. -- tejun