From: Andrew Lunn <andrew@lunn.ch>
To: Jingoo Han <jg1.han@samsung.com>
Cc: 'Zhang Rui' <rui.zhang@intel.com>,
'Eduardo Valentin' <eduardo.valentin@ti.com>,
linux-pm@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH 2/6] thermal: dove: remove unnecessary platform_set_drvdata()
Date: Mon, 6 May 2013 07:12:17 +0200 [thread overview]
Message-ID: <20130506051217.GE2824@lunn.ch> (raw)
In-Reply-To: <003f01ce4a11$fc1b9a90$f452cfb0$@samsung.com>
On Mon, May 06, 2013 at 01:27:14PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/thermal/dove_thermal.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/thermal/dove_thermal.c b/drivers/thermal/dove_thermal.c
> index 4b15a5f..900479e 100644
> --- a/drivers/thermal/dove_thermal.c
> +++ b/drivers/thermal/dove_thermal.c
> @@ -182,7 +182,6 @@ static int dove_thermal_exit(struct platform_device *pdev)
> platform_get_drvdata(pdev);
>
> thermal_zone_device_unregister(dove_thermal);
> - platform_set_drvdata(pdev, NULL);
>
> return 0;
> }
> --
> 1.7.2.5
>
>
Acked-by: Andrew Lunn <andrew@lunn.ch>
prev parent reply other threads:[~2013-05-06 5:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 4:27 [PATCH 2/6] thermal: dove: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-06 5:12 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130506051217.GE2824@lunn.ch \
--to=andrew@lunn.ch \
--cc=eduardo.valentin@ti.com \
--cc=jg1.han@samsung.com \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox