* [PATCH 2/6] thermal: dove: remove unnecessary platform_set_drvdata()
@ 2013-05-06 4:27 Jingoo Han
2013-05-06 5:12 ` Andrew Lunn
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-06 4:27 UTC (permalink / raw)
To: 'Zhang Rui'
Cc: 'Eduardo Valentin', linux-pm, Jingoo Han, Andrew Lunn
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/thermal/dove_thermal.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/thermal/dove_thermal.c b/drivers/thermal/dove_thermal.c
index 4b15a5f..900479e 100644
--- a/drivers/thermal/dove_thermal.c
+++ b/drivers/thermal/dove_thermal.c
@@ -182,7 +182,6 @@ static int dove_thermal_exit(struct platform_device *pdev)
platform_get_drvdata(pdev);
thermal_zone_device_unregister(dove_thermal);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/6] thermal: dove: remove unnecessary platform_set_drvdata()
2013-05-06 4:27 [PATCH 2/6] thermal: dove: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-06 5:12 ` Andrew Lunn
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2013-05-06 5:12 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Zhang Rui', 'Eduardo Valentin', linux-pm,
Andrew Lunn
On Mon, May 06, 2013 at 01:27:14PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/thermal/dove_thermal.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/thermal/dove_thermal.c b/drivers/thermal/dove_thermal.c
> index 4b15a5f..900479e 100644
> --- a/drivers/thermal/dove_thermal.c
> +++ b/drivers/thermal/dove_thermal.c
> @@ -182,7 +182,6 @@ static int dove_thermal_exit(struct platform_device *pdev)
> platform_get_drvdata(pdev);
>
> thermal_zone_device_unregister(dove_thermal);
> - platform_set_drvdata(pdev, NULL);
>
> return 0;
> }
> --
> 1.7.2.5
>
>
Acked-by: Andrew Lunn <andrew@lunn.ch>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-06 5:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 4:27 [PATCH 2/6] thermal: dove: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-06 5:12 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox