From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: Q: acpi-cpufreq module auto-loading after processor driver change
Date: Thu, 6 Jun 2013 15:21:13 -0700 [thread overview]
Message-ID: <20130606222113.GA9271@kroah.com> (raw)
In-Reply-To: <5836546.v3RJP00CT7@vostro.rjw.lan>
On Fri, Jun 07, 2013 at 12:13:58AM +0200, Rafael J. Wysocki wrote:
> On Thursday, June 06, 2013 11:51:54 PM Rafael J. Wysocki wrote:
> > On Thursday, June 06, 2013 01:24:19 PM Greg Kroah-Hartman wrote:
> > > On Thu, May 30, 2013 at 11:38:37PM +0200, Rafael J. Wysocki wrote:
> > > > Hi Greg,
> > > >
> > > > I've noticed during recent testing that with this commit applied:
> > > >
> > > > http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=acpi-hotplug&id=ac212b6980d8d5eda705864fc5a8ecddc6d6eacc
> > > >
> > > > on my openSUSE (and Tubmbleweed) installations I need to modify
> > > > /etc/sysconfig/kernel to make mkinitrd put the acpi-cpufreq module into the
> > > > initramfs or otherwise it won't be loaded automatically.
> > > >
> > > > I think I understand why it needs to be present in the initramfs along the
> > > > processor module for the automatic loading to work (acpi_processor_load_module()
> > > > seems to need that), but before the above commit it wasn't necessary to make
> > > > any changes to /etc/sysconfig/kernel and acpi-cpufreq was loaded automatically
> > > > anyway.
> > > >
> > > > Unfortunately, my experience with udev and related things is kind of limited
> > > > and I have no idea what exactly makes the difference. Can you please have a
> > > > look and help me understand that?
> > >
> > > Don't you need a MODULE_DEVICE_TABLE() macro in that module somewhere so
> > > that udev and the like know to load it when it sees the hardware?
> >
> > Well, that was my first thought about that, but there is one already and my
> > commit hasn't changed it. :-)
>
> My understanding of this is that on x86 (which is the case here)
> topology_init() calls arch_register_cpu() for all available CPUs which
> calls register_cpu() and that causes the uevent to be emitted through
> device_register(). But then, the commit above doesn't change that (at least
> I don't see how).
At first glance, I don't see how either, sorry.
greg k-h
next prev parent reply other threads:[~2013-06-06 22:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 21:38 Q: acpi-cpufreq module auto-loading after processor driver change Rafael J. Wysocki
2013-05-30 21:54 ` Rafael J. Wysocki
2013-06-06 20:24 ` Greg Kroah-Hartman
2013-06-06 21:51 ` Rafael J. Wysocki
2013-06-06 22:13 ` Rafael J. Wysocki
2013-06-06 22:21 ` Greg Kroah-Hartman [this message]
2013-06-06 22:44 ` Rafael J. Wysocki
2013-06-06 23:09 ` Greg Kroah-Hartman
2013-06-07 1:01 ` Rafael J. Wysocki
2013-06-07 2:08 ` [PATCH] ACPI / cpufreq: Add ACPI processor device IDs to acpi-cpufreq Rafael J. Wysocki
2013-06-07 3:33 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130606222113.GA9271@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox