From: Greg KH <gregkh@linuxfoundation.org>
To: Shuah Khan <shuah.kh@samsung.com>
Cc: pavel@ucw.cz, rjw@sisk.pl, len.brown@intel.com, joe@perches.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
shuahkhan@gmail.com
Subject: Re: [PATCH v2] power: Include additional information in pm_print_times
Date: Fri, 14 Jun 2013 13:40:32 -0700 [thread overview]
Message-ID: <20130614204032.GA2912@kroah.com> (raw)
In-Reply-To: <1371242124-11452-1-git-send-email-shuah.kh@samsung.com>
On Fri, Jun 14, 2013 at 02:35:24PM -0600, Shuah Khan wrote:
> Change __device_suspend() path to include driver name and the ops that
> get run for a device. This additional information helps associate the
> driver and the type of pm_ops the device uses in the suspend path very
> quickly which will aid in debugging problems in suspend and resume paths.
> Changed both start and end debug messages to include pm_ops information
> and use dev_info() instead of pr_info().
>
> dmesg output before the change:
>
> [ 164.390032] calling 1-1+ @ 69, parent: usb1
> [ 164.390035] call 1-1+ returned 0 after 0 usecs
>
> [ 164.390352] calling 00:0a+ @ 2457, parent: pnp0
> [ 164.390357] call 00:0a+ returned 0 after 3 usecs
>
> [ 164.390361] calling 00:09+ @ 2457, parent: pnp0
> [ 164.496458] call 00:09+ returned 0 after 103500 usecs
>
> [ 164.496494] calling 00:05+ @ 2457, parent: pnp0
> [ 164.496511] call 00:05+ returned 0 after 14 usecs
>
> dmesg output after the change:
>
> [ 58.707002] usb usb1: calling type pm ops @ 57, parent: 0000:00:1d.0
> [ 58.707641] usb usb1: call type pm ops returned 0 after 611 usecs
>
> [ 58.702014] system 00:0a: calling legacy bus pm ops @ 2173, parent: pnp0
> [ 58.702018] system 00:0a: call legacy bus pm ops returned 0 after 2 usecs
>
> [ 58.702023] tpm_tis 00:09: calling legacy bus pm ops @ 2173, parent: pnp0
> [ 58.806909] tpm_tis 00:09: call legacy bus pm ops returned 0 after 102425 usecs
>
> [ 58.806927] rtc_cmos 00:05: calling legacy bus pm ops @ 2173, parent: pnp0
> [ 58.806935] rtc_cmos 00:05: call legacy bus pm ops returned 0 after 5 usecs
>
> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> ---
> drivers/base/power/main.c | 44 +++++++++++++++++++++++++-------------------
> 1 file changed, 25 insertions(+), 19 deletions(-)
I'm assuming this will go through Rafael's tree:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2013-06-14 20:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 20:35 [PATCH v2] power: Include additional information in pm_print_times Shuah Khan
2013-06-14 20:40 ` Greg KH [this message]
2013-06-14 20:55 ` Joe Perches
2013-06-17 15:06 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130614204032.GA2912@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=shuah.kh@samsung.com \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox