From: Arnd Bergmann <arnd@arndb.de>
To: Tomasz Figa <t.figa@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Kukjin Kim <kgene.kim@samsung.com>,
Olof Johansson <olof@lixom.net>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Thomas Abraham <thomas.abraham@linaro.org>,
linux-pm@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <eduardo.valentin@ti.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH v2 29/38] thermal: exynos: Support both Exynos4x12 SoCs
Date: Mon, 17 Jun 2013 21:59:15 +0200 [thread overview]
Message-ID: <201306172159.15352.arnd@arndb.de> (raw)
In-Reply-To: <1371486863-12398-30-git-send-email-t.figa@samsung.com>
On Monday 17 June 2013, Tomasz Figa wrote:
> diff --git a/drivers/thermal/exynos_thermal.c b/drivers/thermal/exynos_thermal.c
> index 788b1dd..4cbe3ee 100644
> --- a/drivers/thermal/exynos_thermal.c
> +++ b/drivers/thermal/exynos_thermal.c
> @@ -817,7 +817,8 @@ static struct exynos_tmu_platform_data const exynos4210_default_tmu_data = {
> #define EXYNOS4210_TMU_DRV_DATA (NULL)
> #endif
>
> -#if defined(CONFIG_SOC_EXYNOS5250) || defined(CONFIG_SOC_EXYNOS4412)
> +#if defined(CONFIG_SOC_EXYNOS5250) || defined(CONFIG_SOC_EXYNOS4412) || \
> + defined(CONFIG_SOC_EXYNOS4212)
> static struct exynos_tmu_platform_data const exynos_default_tmu_data = {
> .threshold_falling = 10,
> .trigger_levels[0] = 85,
The patch is correct, but generally speaking I think we should get away from
having the drivers get configured per SoC on such a fine-grained level.
Better make this driver (and others) always work on all exynos variants.
Arnd
next prev parent reply other threads:[~2013-06-17 19:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1371486863-12398-1-git-send-email-t.figa@samsung.com>
2013-06-17 16:33 ` [PATCH v2 13/38] ARM: EXYNOS: pm_domains: Remove legacy power domain registration code Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 29/38] thermal: exynos: Support both Exynos4x12 SoCs Tomasz Figa
2013-06-17 19:59 ` Arnd Bergmann [this message]
2013-06-17 23:34 ` Eduardo Valentin
2013-06-18 8:54 ` amit daniel kachhap
2013-06-18 13:02 ` Arnd Bergmann
2013-06-17 16:34 ` [PATCH v2 31/38] cpufreq: exynos4x12: Remove check for SOC_EXYNOS4412 Tomasz Figa
2013-06-18 3:18 ` Viresh Kumar
2013-06-18 9:18 ` Kukjin Kim
2013-06-17 16:34 ` [PATCH v2 33/38] thermal: exynos: " Tomasz Figa
2013-06-18 9:19 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306172159.15352.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=eduardo.valentin@ti.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=olof@lixom.net \
--cc=rui.zhang@intel.com \
--cc=s.nawrocki@samsung.com \
--cc=t.figa@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).