From: Arnd Bergmann <arnd@arndb.de>
To: Eduardo Valentin <eduardo.valentin@ti.com>
Cc: Tomasz Figa <t.figa@samsung.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Kukjin Kim <kgene.kim@samsung.com>,
Olof Johansson <olof@lixom.net>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Thomas Abraham <thomas.abraham@linaro.org>,
linux-pm@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Amit Daniel Kachhap <amit.daniel@samsung.com>
Subject: Re: [PATCH v2 29/38] thermal: exynos: Support both Exynos4x12 SoCs
Date: Tue, 18 Jun 2013 15:02:52 +0200 [thread overview]
Message-ID: <201306181502.52589.arnd@arndb.de> (raw)
In-Reply-To: <51BF9D0A.6050706@ti.com>
On Tuesday 18 June 2013, Eduardo Valentin wrote:
> The driver will work on supported exynos variants. Those that have the
> need for thermal sensing. And each of them have specific thermal needs
> (trigger points, thresholds, etc). That is what this file tries to
> isolate. And there is specific data structures for each soc version.
Correct. My point is that the driver itself is much larger than the
SoC-specific data sets in it. There is no reason to conditionally
build a 108 byte data structure, making it more maintainably by removing
all the #ifdef far outweighs the cost.
You can also change the driver to work only for DT based booting,
that will simplify it further and save you more in terms of object
code size than the exynos_tmu_platform_data instances.
Arnd
next prev parent reply other threads:[~2013-06-18 13:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1371486863-12398-1-git-send-email-t.figa@samsung.com>
2013-06-17 16:33 ` [PATCH v2 13/38] ARM: EXYNOS: pm_domains: Remove legacy power domain registration code Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 29/38] thermal: exynos: Support both Exynos4x12 SoCs Tomasz Figa
2013-06-17 19:59 ` Arnd Bergmann
2013-06-17 23:34 ` Eduardo Valentin
2013-06-18 8:54 ` amit daniel kachhap
2013-06-18 13:02 ` Arnd Bergmann [this message]
2013-06-17 16:34 ` [PATCH v2 31/38] cpufreq: exynos4x12: Remove check for SOC_EXYNOS4412 Tomasz Figa
2013-06-18 3:18 ` Viresh Kumar
2013-06-18 9:18 ` Kukjin Kim
2013-06-17 16:34 ` [PATCH v2 33/38] thermal: exynos: " Tomasz Figa
2013-06-18 9:19 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306181502.52589.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=amit.daniel@samsung.com \
--cc=eduardo.valentin@ti.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=olof@lixom.net \
--cc=rui.zhang@intel.com \
--cc=s.nawrocki@samsung.com \
--cc=t.figa@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).